Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixedKeyAndMaskConstraint limit to a single BaseKeyAndMask #438

Closed
Christian-B opened this issue Jun 29, 2022 · 4 comments
Closed

FixedKeyAndMaskConstraint limit to a single BaseKeyAndMask #438

Christian-B opened this issue Jun 29, 2022 · 4 comments
Assignees
@Christian-B
Labels
enhancement

Comments

@Christian-B
Copy link
Member

For some reason FixedKeyAndMaskConstraint
Inputs and outputs an iterable of BaseKeyAndMask

yet all known use case take just 1.

Does it even makes sense for there to be multiple FIXED KeysandMasks on one partition?

Suggest we change it to only accept 1 BaseKeyAndMask
@Christian-B
Copy link
Member Author

This would also avoid the ugly and incorrect eg and hash functions!

@Christian-B
Copy link
Member Author

@rowleya commented on skype "Yes, happy to drop to 1 key and mask"

@Christian-B Christian-B assigned Christian-B and unassigned rowleya Jun 29, 2022
@Christian-B Christian-B mentioned this issue Aug 2, 2022
Open
@Christian-B
Copy link
Member Author

#463 removes the whole FixedKeyAndMaskConstraint which of course makes this issue no longer exists

@Christian-B
Copy link
Member Author

Done by #464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Christian-B Christian-B

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Christian-B @rowleya