Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ElementAllocatorAlgorithm and KeySpaceTracker after reduce_overhead_data_spec #465

Open
Christian-B opened this issue Sep 15, 2022 · 3 comments
Assignees
Labels

Comments

@Christian-B
Copy link
Member

is there any reason to have a separate ElementAllocatorAlgorithm when its only use is as a parent to KeySpaceTracker

if you agree it can be merged assign to me.

@rowleya
Copy link
Member

rowleya commented Sep 15, 2022

Happy for it to be merged. At the lastest check, in reduce_overhead_data_spec, that class is unused.

@Christian-B
Copy link
Member Author

Only use of KeySpaceTracker in master was SynapticMatrices.

Agreed
https://github.com/SpiNNakerManchester/sPyNNaker/blob/reduce_overhead_data_spec/spynnaker/pyNN/models/neuron/synaptic_matrices.py no longer uses it.

My suggestion is in that branch remove both the KeySpaceTracker and the ElementAllocatorAlgorithm rather than wasting time merging them.

@rowleya
Copy link
Member

rowleya commented Sep 15, 2022

Agreed. I will remove from the branch. There is no PACMAN branch there so that can be removed separately later (so probably leave this open until then).

@Christian-B Christian-B changed the title Merge ElementAllocatorAlgorithm into KeySpaceTracker Remove ElementAllocatorAlgorithm and KeySpaceTracker after reduce_overhead_data_spec Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants