Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Use custom file tree walker instead of globby #1599

Merged
merged 1 commit into from
Sep 17, 2024
Merged

🐛 Use custom file tree walker instead of globby #1599

merged 1 commit into from
Sep 17, 2024

Conversation

SPGoding
Copy link
Member

Fix #1572.

@misode misode self-requested a review September 17, 2024 00:42
misode
misode approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@misode misode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this, I can confirm it fixes the "cannot find pack.mcmeta" issue.

However it does not fix the more general issue where symbols are not found. After some debugging I realized this is a completely separate problem, so I'll create a new issue for it.

packages/java-edition/src/index.ts Show resolved Hide resolved
@misode misode mentioned this pull request Sep 17, 2024
Merged
@SPGoding SPGoding merged commit c67a9b6 into main Sep 17, 2024
3 checks passed
@SPGoding SPGoding deleted the fs-tree-walk branch September 17, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misode misode misode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find pack.mcmeta when projectRoot is "complex"
2 participants
@SPGoding @misode