Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedundantMaster and TwemProxy #1828

Closed
rkarthick opened this issue Aug 12, 2021 · 6 comments
Closed

RedundantMaster and TwemProxy #1828

rkarthick opened this issue Aug 12, 2021 · 6 comments

Comments

@rkarthick
Copy link
Contributor

rkarthick commented Aug 12, 2021

When we are connecting to multiple proxy instances (n proxies), preferred master nomination nullifies the benefit of having multiple proxy instances and marks n-1 proxies as unselectable with the reason RedundantMaster thereby forcing the selection to choose only a single fixed node all the time. Is the preferred master nomination supposed to kick in for twemproxy mode?

PS: I am using TwemProxy mode for connecting to a set of envoy proxies

@rkarthick
Copy link
Contributor Author

@mgravell are you able to help :)? Looking to see if this behavior of tagging proxies as a redundant master a legit behavior or a bug. TIA

@NickCraver
Copy link
Collaborator

Can you share more info on the topology? e.g. are all these proxies in front of the same servers? And what would you want to happen? e.g. we issue commands to a random one? or round robin?

The current behavior is expected based on your description, but knowing what you'd want to happen here would help advise :)

@rkarthick
Copy link
Contributor Author

Hi Nick, Sorry I should tweak my notifications in github. I just saw your comment.

With Envoy proxy the configuration is such that, there will be multiple proxies fronting a set of same redis servers. The desired behavior here would be to use round robin or random for envoy proxy. I will share the idea in a separate PR to get your comments on the concrete idea. Thanks!

@rkarthick
Copy link
Contributor Author

#1977 Would love to get your thoughts on the PR

@NickCraver NickCraver self-assigned this Feb 8, 2022
@NickCraver
Copy link
Collaborator

@rkarthick Are we good to close this one out? Thanks again for all your effort here!

@rkarthick
Copy link
Contributor Author

Yes, we are good to close this one. Thank you for all your help in this <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants