Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit coverage reports to codecov.io on master merge #4270

Merged
merged 7 commits into from
Jul 25, 2018
Merged

Submit coverage reports to codecov.io on master merge #4270

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
23a5052
Add a comment, move echo to before_script step.
Kami Jul 25, 2018
769832d
Temporary use my fork which will allow to more easily debug the issues.
Kami Jul 25, 2018
7694cc2
Fix typo.
Kami Jul 25, 2018
031d713
Temporary enable coverage so i can test coveralls reporting.
Kami Jul 25, 2018
7c40ecd
Install eventlet library which is needed for "coverage combine" step to
Kami Jul 25, 2018
66675e5
Remove debug stuff, coverage submission to coveralls is working again.
Kami Jul 25, 2018
26ab4e4
Fix typo.
Kami Jul 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ branches:
env:
global:
- CACHE_NAME=JOB1
# NOTE: We only enable coverage for master builds and not pull requests
# since it has huge performance overhead (etests are 50% or so slower)
- ENABLE_COVERAGE=$([ "${TRAVIS_PULL_REQUEST}" = "false" ] && echo "yes" || echo "no")
matrix:
include:
Expand Down Expand Up @@ -64,14 +66,16 @@ before_install:
- sudo pip install --upgrade "virtualenv==15.1.0"

install:
- "echo ${ENABLE_COVERAGE}"
- if [ "${TASK}" = 'compilepy3 ci-py3-unit' ] || [ "${TASK}" = 'ci-py3-integration' ]; then pip install "tox==3.0.0"; else make requirements; fi
- if [ "${TASK}" = 'ci-unit' ] || [ "${TASK}" = 'ci-integration' ] && [ "${ENABLE_COVERAGE}" = 'yes' ]; then pip install codecov; fi
# NOTE: We need eventlet installed so coverage can be correctly combined. This is needed because we are covering code which utilizes eventlet.
# Without eventlet being available to the coverage command it will fail with "Couldn't trace with concurrency=eventlet, the module isn't installed."
- if [ "${TASK}" = 'ci-unit' ] || [ "${TASK}" = 'ci-integration' ] && [ "${ENABLE_COVERAGE}" = 'yes' ]; then pip install eventlet ; pip install -e "git+https://github.com/Kami/codecov-python.git@better_error_output#egg=codecov"; fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Kami/ 🙄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fork it to the StackStorm org and move it there.

Hopefully upstream project will merge the fix shortly and submit a new version to PyPi.

- if [ "${TASK}" = 'ci-unit' ] || [ "${TASK}" = 'ci-integration' ] || [ "${TASK}" = 'compilepy3 ci-py3-unit' ] || [ "${TASK}" = 'ci-py3-integration' ]; then sudo .circle/add-itest-user.sh; fi

# Let's enable rabbitmqadmin
# See https://github.com/messagebus/lapine/wiki/Testing-on-Travis.
before_script:
- "echo ENABLE_COVERAGE=${ENABLE_COVERAGE}"
- git --version
- pip --version
- virtualenv --version
Expand Down