Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panics if Camera::hdr is true #354

Closed
johanhelsing opened this issue Nov 23, 2022 · 0 comments · Fixed by #357
Closed

Panics if Camera::hdr is true #354

johanhelsing opened this issue Nov 23, 2022 · 0 comments · Fixed by #357

Comments

@johanhelsing
Copy link
Contributor

Encountered this when wanting to try out the new bloom effect.

From 778682b08320ac55f8b55ecb0e18a79fed8c8b0e Mon Sep 17 00:00:00 2001
From: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
Date: Wed, 23 Nov 2022 21:45:00 +0100
Subject: [PATCH] Trigger bloom panic

---
 examples/basic.rs | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/basic.rs b/examples/basic.rs
index 9ce731e..2f527a4 100644
--- a/examples/basic.rs
+++ b/examples/basic.rs
@@ -10,7 +10,9 @@ fn startup(
         ArrayTextureLoader,
     >,
 ) {
-    commands.spawn(Camera2dBundle::default());
+    let mut cam = Camera2dBundle::default();
+    cam.camera.hdr = true;
+    commands.spawn(cam);

     let texture_handle: Handle<Image> = asset_server.load("tiles.png");

--
2.35.1.windows.2
dev/bevy_ecs_tilemap main ~1 cargo run --example basic
warning: unused manifest key: target.wasm32-unknown-unknown.runner
   Compiling bevy_ecs_tilemap v0.9.0 (C:\Users\Johan\dev\bevy_ecs_tilemap)
    Finished dev [unoptimized + debuginfo] target(s) in 3.64s
     Running `target\debug\examples\basic.exe`
2022-11-23T20:44:03.130145Z  INFO bevy_render::renderer: AdapterInfo { name: "NVIDIA GeForce GTX 970", vendor: 4318, device: 5058, device_type: DiscreteGpu, driver: "NVIDIA", driver_info: "522.25", backend: Vulkan }
2022-11-23T20:44:03.388691Z ERROR wgpu::backend::direct: Handling wgpu errors as fatal by default
thread 'main' panicked at 'wgpu error: Validation Error

Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 2, Vulkan)>`
    In a set_pipeline command
      note: render pipeline = `tilemap_pipeline`
    Render pipeline targets are incompatible with render pass
    Incompatible color attachment: the renderpass expected [Some(Rgba16Float)] but was given [Some(Rgba8UnormSrgb)]

', C:\Users\Johan\.cargo\registry\src\gitpro.ttaallkk.top-1ecc6299db9ec823\wgpu-0.14.0\src\backend\direct.rs:2403:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: process didn't exit successfully: `target\debug\examples\basic.exe` (exit code: 101)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant