Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with release@1.2.3 #18

Closed
rackstar17 opened this issue Feb 27, 2020 · 2 comments
Closed

Issue with release@1.2.3 #18

rackstar17 opened this issue Feb 27, 2020 · 2 comments

Comments

@rackstar17
Copy link

rackstar17 commented Feb 27, 2020 •
edited
Loading

I got the following error while making the frontend build -

ReferenceError: window is not defined

561 | at Object. (/usr/src/app/node_modules/react-scrollspy-nav/dist/ScrollspyNav.js:1:286)

We're using react(15.6.2), react-dom(16.13.0)
Is it a backwards compatibility issue ?

I was previously using version 1.2.1 and it worked fine.
@StephenWeiXu
Copy link
Owner

@rackstar17 Thanks for bringing it up. Looking into it

@StephenWeiXu
Copy link
Owner

StephenWeiXu commented Feb 27, 2020 •
edited
Loading

@rackstar17 Please try upgrading react version to 16 and try it again.

You might see a general warning about react and react-dom version(see below) as well when you do npm install in your package.

npm WARN react-dom@16.13.0 requires a peer of react@^16.0.0 but none is installed. You must install peer dependencies yourself.

@Bathlamos Bathlamos mentioned this issue Apr 13, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rackstar17 @StephenWeiXu