You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Decided to look into our coverage as part of #300because I actually decreased it during my first draft, oops
Most seem easy to address, just wanted to open this thread for these two:
file path
coverage
notes
/Scripts/Input/Controls.cs
0.00%
auto-generated
/Scripts/Attributes/Editor/ReadOnlyDrawer.cs
0.00%
editor-only code
I'd say, auto-generated and editor-only files are safe to ignore for coverage.
However: While we could easily exclude /Scripts/Attributes/*, the only way to ignore Controls.cs at the moment, is by explicitly ignoring that single file. Ignoring individual files feels weird to me, maybe we could move it into /unity-ggjj/Assets/Scripts/Input/AutoGenerated and exclude those directories?
Remaining files that should be fairly intuitive to cover:
file path
coverage
notes
/Scripts/UI/QuitGame.cs
20.00%
need to see if the test runner survives the call to Application.Quit()
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Decided to look into our coverage as part of #300 because I actually decreased it during my first draft, oops
Most seem easy to address, just wanted to open this thread for these two:
/Scripts/Input/Controls.cs
/Scripts/Attributes/Editor/ReadOnlyDrawer.cs
I'd say, auto-generated and editor-only files are safe to ignore for coverage.
However: While we could easily exclude
/Scripts/Attributes/*
, the only way to ignoreControls.cs
at the moment, is by explicitly ignoring that single file. Ignoring individual files feels weird to me, maybe we could move it into/unity-ggjj/Assets/Scripts/Input/AutoGenerated
and exclude those directories?Remaining files that should be fairly intuitive to cover:
/Scripts/UI/QuitGame.cs
Application.Quit()
/Scripts/UI/ControlButton.cs
/Scripts/Menu/SplashScreen.cs
/Scripts/Menu/NarrativeCase.cs
/Scripts/Menu/CaseSelectMenu.cs
/Scripts/Menu/ChapterSelectMenu.cs
Beta Was this translation helpful? Give feedback.
All reactions