Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI doesn't set base url as server #223

Closed
KiriKira opened this issue Aug 29, 2023 · 2 comments · Fixed by #224
Closed

WebUI doesn't set base url as server #223

KiriKira opened this issue Aug 29, 2023 · 2 comments · Fixed by #224

Comments

@KiriKira
Copy link

PLEASE READ THIS

I acknowledge that:

  • I have updated to the latest version of the app.
  • I have tried the troubleshooting guide described in README.md
  • If this is a request for adding/changing an extension it should be brought up to Tachiyomi: https://github.com/tachiyomiorg/tachiyomi-extensions/issues/new/choose
  • If this is an issue with some extension not working properly, It does work inside Tachiyomi as intended.
  • I have searched the existing issues and this is a new ticket NOT a duplicate or related to another open issue
  • I will fill out the title and the information in this template

Note that the issue will be automatically closed if you do not fill out the title or requested information.

DELETE THIS SECTION IF YOU HAVE READ AND ACKNOWLEDGED IT


Describe the bug
WebUI doesn't set base url as server as described in #60

To Reproduce
Steps to reproduce the behavior:

  1. run tachidesk-server via docker with latest image
  2. set server.webUIFlavor = "Custom" in server.conf
  3. put sorayomi web 0.5.10 in webUI directory
  4. open the web, and the server is defaultly set to 127.0.0.1:4567

Expected behavior
set server to base url, if detect base url is using http or https via normal port 80/443, disable port setting.

Screenshots
image

Device information (Server)

  • Tachidesk version: ghcr.io/suwayomi/tachidesk:v0.7.0-ubuntu
  • Server Operating System: docker
  • Server Desktop Environment: N/A
  • Server JVM version: N/A

Device information (Client)

  • Client version: 0.5.10
  • Client Type:Web
  • Client Web Browser: Microsoft Edge Version 116.0.1938.54 (Official build)
@DattatreyaReddy
Copy link
Collaborator

i'll implement this feature for the next release.

@DattatreyaReddy
Copy link
Collaborator

DattatreyaReddy commented Aug 29, 2023

Now Server Port will be disabled by default for the web.

Sorayomi will take the Browser origin URL as server URL in web
for Ex:

URL = http://nas:4569/#/more is the URL then http://nas:4569 will be the server URL by default

you can change these settings BTW.(Changes will be released in next version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants