-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The NS prefix should only be used by Apple #57
Comments
It true, that was a bit of an unfortunate decision that happened that happened in one of the late nights eary in the project. We might fix this somewhen, but security, stability and UX are more important right now. Would you be interested to start a PR? |
Alright, I will remove the prefixes and create a PR |
Great. A few remarks:
|
As the code base is not changing much anymore, are you still interested in updating the pull-request? |
according to the Apple's docs the NS and UI prefixes are exclusively for Apple classes,
otherwise your own classes could collide with future apple's classes
e.g.:
NSTracingErrorView
NSSimpleModuleBaseView
UIStateManager
You Actually don't need class prefixes in Swift
Solution:
You could either create your own Prefix (following the Objective-C Prefix convention) or remove it completely
Why This should be fixed
At the moment users might imply that those classes are coming from Apple, and look for its documentation on Apple's doc page
The text was updated successfully, but these errors were encountered: