-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How are parameters passed around? #71
Comments
This seems to come from here: https://github.com/DP-3T/dp3t-sdk-ios/blob/master-alpha/Sources/DP3TSDK/DP3TTracing.swift#L45 If I check the caller of And requested to the server here: https://github.com/DP-3T/dp3t-app-ios-ch/blob/develop/DP3TApp/Logic/Config/ConfigManager.swift#L73 If I understood correctly, you are asking how this is passed through the app? Then I guess you found the relevant config on the server-side. Let me know if you need more explanations @pdehaye 😀 |
I got more explanations in the interim through a public call with the DP3T team. It looks like they are not using a lot of the configuration options of the API, and only relying on the Still need to dig deeper for this. |
Ok, much easier for me to do with the information I just got in the seminar today. (EDIT: goes on to paste code not relevant to this repo, since concerns Android version only:)
|
This document was just posted, clarifying many of my questions so far. Thanks! |
(The text below actually applicable only to Android, wrong repo)
|
(a lot was wrongly posted here about Android, so has been moved to DP-3T/dp3t-app-android-demo#62) |
I would like to understand if this iOS SDK code to fetch parameters and configure the API is run via the iOS app, and if so how/where? Could you please tell me more? |
Is this a good start to find an answer to your question? https://github.com/DP-3T/dp3t-app-ios-ch/blob/35fca01de72c4c8eacbe11485b21523fe3750ead/DP3TApp/Logic/Config/ConfigManager.swift#L131 |
Yes, so good that this is also where I started this issue ;-) So, to be more precise, is this code from the SDK run in the app now? If so what is the logic behind it? A minimum risk score of 0 if set, and all the events are marked as "at risk" (through nonsensical parameters), so then some risk calculation can actually be done based on the triples of weight and attenuation values, obtained from the ExposureSummary? That logic still runs in the app now? |
The usage of the EN API is explained in EXPOSURE_NOTIFICATION_API_USAGE.md. If you think there is something missing or still unclear, let us know. |
Thanks, that confirms to me what that my understanding was correct, and the code is still running. |
I have tried understanding how parameters are passed to the app.
I found some relevant code server side, which feeds into the bit below.
https://github.com/DP-3T/dp3t-app-ios-ch/blob/44ee83cd9f9911b4725ac42f7a576a2af6c061b1/DP3TApp/Logic/Config/ConfigManager.swift#L127-L137
Could you please tell me more?
This is related to PersonalDataIO/CoronaRiskScoring#3
The text was updated successfully, but these errors were encountered: