-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Even after disabling 'Enable chat output in media player' chat messages is still shown #610
Comments
I think there might be a mismatch between what people might expect from how it is described and how it was originally intended and ultimately implemented. Historically Syncplay only ever supported one-line-at-a-time OSD, which was fine for most purposes but didn't support multiple chat messages being shown at once. For most players it wasn't possible to do that in a reliable way, but for mpv I could do so by bypassing the normal OSD system and instead using a custom OSD system to better support chat. It is this special OSD which I was referring to when I added the "Enable chat output in media player (mpv only for now)". So if that feature is enabled, chat messages show up on multiple lines and if it is disabled it shows up on the top line (if OSD messages overall are enabled). I'm reluctant to change the behaviour of a long-implemented option, but I would be happy to consider (a) tweaking the wording to make it more clear what the option means, and (b) having an explicit option to allow people to enable/disable chat messages (which is the behaviour you were expecting for the "Enable chat output" option) in the messages tab. |
Regardless of what this setting does, disabling it causes an error for me on closing Syncplay:
Here's what's in the log: Click to see log contents
Enabling chat output again gets rid of this error. |
Describe the bug
Even after disabling 'Enable chat output in media player' chat messages is still shown in mpv.net.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
No chat messages.
Version and platform:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: