Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version info to web client footer #23

Open
peterstadler opened this issue Sep 21, 2022 · 2 comments
Open

add version info to web client footer #23

peterstadler opened this issue Sep 21, 2022 · 2 comments
Assignees

Comments

@peterstadler
Copy link
Member

Only the version of the TEIGarage, more details can be found at the Info endpoint

@sydb
Copy link
Member

sydb commented Apr 14, 2023

I am not 100% sure what @peterstadler means by the initial comment, but my first instinct is that I should not have to use the API to get version information, it should be displayed on the page. Perhaps even in a separate box that has a “copy this” button.

Furthermore, or perhaps even more importantly, the version information should be included in the output document. (I realize that a lot of that work belongs to the Stylesheets, not TEIGarage; but TEIGarage is responsible for the first step, putting a proper <appInfo> in the TEI before it is shipped out or converted to something else.)

The version information that should be available includes:

  • Stylesheets version
  • TEIGarage version
  • Edition statement from input TEI (if any)
  • p5subset version (if applicable)

@peterstadler
Copy link
Member Author

The initial comment was about constraining this issue, so it's only about adding TEIGarage version info (currently v1.1.1) to the web client footer.
But @sydb's probably right that it makes good sense to include also Stylesheets version and p5subset version to the TEIGarage web client footer.

Injecting version information into the output document is a bit more tricky and deserves a ticket on its own. And I wonder whether this should be a Stylesheets issue rather a TEIGarage issue since (for TEI output formats) the TEIGarage is really only a frontend/interface to the Stylesheets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants