Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Negative Profit #486

Open
RonSwanson2 opened this issue Mar 22, 2021 · 2 comments · Fixed by #545 or #548
Open

Error with Negative Profit #486

RonSwanson2 opened this issue Mar 22, 2021 · 2 comments · Fixed by #545 or #548
Labels
bug Something isn't working

Comments

@RonSwanson2
Copy link

RonSwanson2 commented Mar 22, 2021

When givePrice is disabled and unknown incoming offers that are not part of the bots pricelist are received it shows the price as "0 keys, 0 ref". This is proper. However if the invalid offer gets accepted and the item becomes part of the pricelist and furthers to still dissipate the amount of value that item/items had. It shows as a negative profit after doing !stats after that invalid offer trade.

Steps to reproduce the behavior:

  1. givePrice=false
  2. autoAcceptOverpay=true
  3. Offer a trade with multiple items where one of those items is not part of the pricelist.
  4. !stats
  5. Check if profit became negative.

I expected that the bot recognized that the items were not actually worth "0 keys, 0 ref" and understood that I have profited from that invalid trade.
The image below is !stats before the invalid offer trade.
image
image
image

Version: 3.7.0

@RonSwanson2 RonSwanson2 added the bug Something isn't working label Mar 22, 2021
@idinium96
Copy link
Member

Thanks for the report

@RonSwanson2
Copy link
Author

Thanks for the report

No problem. I want the github contributor role for doing nothing now lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants