Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI & GUI functionality to persist VU settings automatically across restarts #698

Closed
v1k1nghawk opened this issue Apr 24, 2024 · 2 comments · Fixed by #696
Closed

Add CLI & GUI functionality to persist VU settings automatically across restarts #698

v1k1nghawk opened this issue Apr 24, 2024 · 2 comments · Fixed by #696

Comments

@v1k1nghawk
Copy link
Contributor

v1k1nghawk commented Apr 24, 2024

Is your feature request related to a problem? Please describe.
The current behavior of CLI & GUI requires updating Virtual Users settings manually before (using giset) or after each restart. It’s better to allow the vuset command (CLI) and Virtual Users Options menu (GUI) to save the setting to storage to improve consistency and speed of continuing benchmarking across restarts.

Describe the solution you'd like
Dynamically write the VU settings to generic.db using the vuset command / Virtual Users Options menu confirmation.

Describe alternatives you've considered

  1. Update the VU settings in genericdict during vuset and write everything from genericdict to SQLite on exit, but it’s better to save data to the storage earlier.
  2. Save the VU settings to genericdict and to SQLite (during vuset) to keep them in sync (to avoid side effects such as print generic outputs outdated VU data). In this case, it is logical to modify giset too.

Additional context
PR that solves the issue. The behavior and internals are similar to giset but automate frequent VU operations.

@sm-shaw
Copy link
Contributor

sm-shaw commented Apr 30, 2024

Have reviewed and approved PR with additional update 5ff2f8a

@sm-shaw sm-shaw linked a pull request Apr 30, 2024 that will close this issue
@sm-shaw
Copy link
Contributor

sm-shaw commented Apr 30, 2024

Closing Issue as PR #696 merged

@sm-shaw sm-shaw closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants