Add within_hours and within_days query options #60
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ebanner
force-pushed
the
add-withinHours-and-withinDays-query-options
branch
2 times, most recently
from
86af21e
to
dbf0f88
Compare
ebanner
force-pushed
the
add-withinHours-and-withinDays-query-options
branch
from
cb39f93
to
189a31e
Compare
|
Hey @ebanner! I’ve been meaning to get to reviewing your PR and have some feedback. This week is packed for me, but I’ll do my best to knock the review out within the next day or so. |
There was a problem hiding this comment.
Taking a look at this @ebanner
I think you probably want these changes in the filterEventData from the Util library class. It handles the params and filtering the data down, which these within_hours=x and within_days=x match.
This appears to work outside of that filtering the data down further, which seems out of place given the param filtering is inside that util.
|
Ah, good call @iBotPeaches! I guess I missed that function. I moved it over 👍 |
ebanner
force-pushed
the
add-withinHours-and-withinDays-query-options
branch
2 times, most recently
from
ede8095
to
30e4415
Compare
Also add dummy /favicon.ico route
ebanner
force-pushed
the
add-withinHours-and-withinDays-query-options
branch
from
30e4415
to
7398dcc
Compare
|
@ebanner Great work on this-- stoked to see it merged! Shoutout to @iBotPeaches also for taking point on code review ❤️ |
Addresses #57 (comment)
This PR adds
within_hoursandwithin_daysquery options to the API, so that clients may request events that areXhours out orXdays out from now.Notes
I was tempted to abstract the filtering logic into a partial function, but opted to duplicate the code for simplicity.
Also, the browser was requesting a favicon, which was messing with development. I put a check in at the top of the request loop to return, but I'm not sure if it's actually being handled property or not.