Removal of boost::asio dependency
#19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to link with Boost system library anymore. Standalone asio is also compatible with std::system_error and std::error_code. This commit removes all boost dependencies present in the codebase.
Check rosdep/base.yml for more info.
|
I tested the PR by using a TCP connection through a docker container (as specified in https://github.com/nocoinman/mosaicgnss-dev). And from the results, it seems to work fine, i.e. it is able to connect and get data from the specified IP and port, and then parse the data. It also publishes to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
boost::asioandboost::systemdependencies with standaloneasioandstd::system_errorandstd::error_code. This allows us to completely remove any Boost dependency. This ideally shouldn't break the code in any way, but this would still require testing with the hardware to confirm (cc @nocoinman).Fixes #15.