Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add Windows builds back #1274

Closed
Panquesito7 opened this issue Jun 11, 2023 · 5 comments · Fixed by #1290
Closed

[FEATURE] Add Windows builds back #1274

Panquesito7 opened this issue Jun 11, 2023 · 5 comments · Fixed by #1290
Assignees
Labels
dont-close This issue/pull request shouldn't be closed enhancement New feature or request

Comments

@Panquesito7
Copy link
Member

Detailed description

Many people still develop and test algorithms on Windows, not only in Linux or MacOS.
However, this repository only has Linux and MacOS support, which if not well-tested on Windows, the code may have errors.

I suggest adding back the Windows builds. There are a few errors, but those can be fixed.

Context

  1. Windows users do not have to worry about errors or unwanted things happening when building.
  2. This ensures the code works perfectly fine on the latest Windows versions.
  3. MSVC (sometimes) catches a few other errors the other compilers do not.

Possible implementation

Add Windows builds back.

Additional information

I'd like to work on this, if agreed to add them back.

@Panquesito7 Panquesito7 added the enhancement New feature or request label Jun 11, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jul 12, 2023
@github-actions
Copy link
Contributor

Please ping one of the maintainers once you add more information and updates here. If this is not the case and you need some help, feel free to ask for help in our Gitter channel or our Discord server. Thank you for your contributions!

@Panquesito7 Panquesito7 reopened this Jul 19, 2023
@Panquesito7 Panquesito7 added dont-close This issue/pull request shouldn't be closed and removed Stale labels Jul 19, 2023
@Panquesito7 Panquesito7 self-assigned this Jul 19, 2023
@Panquesito7
Copy link
Member Author

Looks like Scilab has the fork function implemented in Windows. https://github.com/scilab/scilab/tree/master/scilab/modules/parallel/src/c
What do you folks think? Should we give it a try?

@realstealthninja
Copy link
Collaborator

Looks like Scilab has the fork function implemented in Windows. https://github.com/scilab/scilab/tree/master/scilab/modules/parallel/src/c
What do you folks think? Should we give it a try?

I think it's worth the shot if it works then we're good to go!

@ldo
Copy link

ldo commented Aug 11, 2023

You could just support building the code under Cygwin. That would give you a more Unix/Linux-like environment than native Windows can manage on its own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-close This issue/pull request shouldn't be closed enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants