Skip to content

Commit

Permalink
Roll back buildkit version (#758)
Browse files Browse the repository at this point in the history
* Roll back buildkit version
* Add extra debug flag. Only use opts where necessary.
* Buildx needs same version to reuse cache.
* Add a bit more context to the comments in the build.
  • Loading branch information
jonathangreen committed Jan 18, 2023
1 parent 29f3de2 commit 0af51f4
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions .github/workflows/test-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,17 @@ jobs:
- name: Set up QEMU
uses: docker/setup-qemu-action@v2

# TODO: We can remove the `with` statement here once these open upstream issues are resolved
# https://github.com/docker/build-push-action/issues/761
# https://github.com/moby/buildkit/issues/3347
# It was added to stop an issue we saw in buildkit v0.11 where builds were failing to
# push with the error:
# failed to copy: io: read/write on closed pipe
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
with:
driver-opts: image=moby/buildkit:v0.10.6
buildkitd-flags: --debug

- name: Create version file
run: git rev-parse --short HEAD > .version
Expand Down Expand Up @@ -118,8 +127,12 @@ jobs:
- name: Set up QEMU
uses: docker/setup-qemu-action@v2

# TODO: See comment in the docker-image-build section for setup-buildx-action
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
with:
driver-opts: image=moby/buildkit:v0.10.6
buildkitd-flags: --debug

- name: Create version file
run: git rev-parse --short HEAD > .version
Expand Down Expand Up @@ -169,8 +182,12 @@ jobs:
- name: Set up QEMU
uses: docker/setup-qemu-action@v2

# TODO: See comment in the docker-image-build section for setup-buildx-action
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
with:
driver-opts: image=moby/buildkit:v0.10.6
buildkitd-flags: --debug

- name: Create version file
run: git rev-parse --short HEAD > .version
Expand Down

0 comments on commit 0af51f4

Please sign in to comment.