Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Roll back buildkit version (#758)" #768

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

jonathangreen
Copy link
Member

Description

This PR reverts the changes made in #758 (commit 0af51f4).

Motivation and Context

In an update on the upstream issue docker/build-push-action#761 (comment), this has been resolved with the release of a new version of buildkit (v0.11.2), so we can roll back the mitigation we put in place to keep our docker images building.

How Has This Been Tested?

Should be good to go if CI passes and docker containers build. Would be good to check the build logs to make sure that buildkit v0.11.2 is what gets installed by CI.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen requested a review from a team January 27, 2023 13:17
@jonathangreen
Copy link
Member Author

Just confirmed that buildkit v0.11.2 is installed by the action:
https://github.com/ThePalaceProject/circulation/actions/runs/4024799326/jobs/6917233696#step:4:141

Copy link
Contributor

@tdilauro tdilauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jonathangreen jonathangreen merged commit ec10dbe into main Jan 27, 2023
@jonathangreen jonathangreen deleted the bugfix/update-to-latest-buildkit branch January 27, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants