Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use Go's plugin feature #24

Closed
fractalqb opened this issue Oct 7, 2021 · 2 comments
Closed

Why use Go's plugin feature #24

fractalqb opened this issue Oct 7, 2021 · 2 comments

Comments

@fractalqb
Copy link

fractalqb commented Oct 7, 2021

Go's plugin package seem to be a little like an "unloved child" in the Go community. And it is not (yet?) ready for Windows. Windows is not my problem but it might lock out quite some users. And it interferes with Go's sore feature of platform independence.

Apart from that I don't see the benefit. The RAA package is mandatory in the current theragile exe. You cannot run threagile -raa-plugin "". It simply fails with plugin.Open(""): realpath failed. So what's the point in making RAA being a plugin if it must be there in the end. It would be much simpler with the default static linking of Go.

@ezavgorodniy
Copy link
Collaborator

Absolutely agree with you and had the same feeling when tried to run this locally. Seems like @joreiche had the same feelings and had introduced a solution to achieve flexibility by meta script language in yaml: https://github.com/Threagile/threagile/blob/master/pkg/security/risks/scripts/accidental-secret-leak.yaml

This is not a feature that can be used from latest docker image although we're working on making an official release of Threagile 1.0 which will contain it.

P. S. I'm aware about lack of documentation on script rules, it's something that other contributors have in their TODO list

@joreiche
Copy link
Collaborator

the latest version uses a regular binary as a plugin and passes data via stdin/stdout/stderr to this issue no longer exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants