Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Athena join syntax #24

Closed
drizk1 opened this issue Jun 3, 2024 · 0 comments · Fixed by #25
Closed

Fix Athena join syntax #24

drizk1 opened this issue Jun 3, 2024 · 0 comments · Fixed by #25

Comments

@drizk1
Copy link
Member

drizk1 commented Jun 3, 2024

Right now, joins with Athena require an extra argument, athena_params. I realize now that the params are stored in the query struct, so this can be easily changed to match the join syntax of all other backends.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes join syntax for athena TidierOrg/TidierDB.jl
1 participant
@drizk1