From 260b6a94fecc9f2c29c573311c762519792931a5 Mon Sep 17 00:00:00 2001
From: Tomoki Miyauchi <development.operation.6.6.6@gmail.com>
Date: Sun, 16 Jun 2024 15:53:50 +0900
Subject: [PATCH] feat(plugin): resolve data url to native instead of deno info

---
 .gitignore    |  1 +
 src/load.ts   | 12 ------------
 src/plugin.ts | 52 ++++++++++++++++++++++++++++++++++++++++++---------
 3 files changed, 44 insertions(+), 21 deletions(-)
 create mode 100644 .gitignore

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..eb5a316
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
+target
diff --git a/src/load.ts b/src/load.ts
index 36de427..9728409 100644
--- a/src/load.ts
+++ b/src/load.ts
@@ -6,18 +6,6 @@ import { fromFileUrl } from "@std/path/from-file-url";
 import type { PluginData } from "./types.ts";
 import { mediaTypeToLoader, resolveLongestExt } from "./utils.ts";
 
-export async function loadDataURL(
-  url: URL,
-  pluginData: PluginData,
-): Promise<OnLoadResult> {
-  const result = await fetch(url);
-  const contents = await result.text();
-  const loader = pluginData.mediaType &&
-    mediaTypeToLoader(pluginData.mediaType);
-
-  return { contents, loader };
-}
-
 export async function loadFileURL(
   url: URL,
   pluginData: PluginData,
diff --git a/src/plugin.ts b/src/plugin.ts
index abdb60a..9ee8bfa 100644
--- a/src/plugin.ts
+++ b/src/plugin.ts
@@ -1,4 +1,4 @@
-import { info, type InfoOptions } from "@deno/info";
+import { info, type InfoOptions, MediaType } from "@deno/info";
 import type { LogLevel, Plugin } from "esbuild";
 import { DenoDir } from "@deno/cache-dir";
 import { fromFileUrl } from "@std/path/from-file-url";
@@ -8,11 +8,12 @@ import { type LevelName } from "@std/log/levels";
 import { setup } from "@std/log/setup";
 import { ConsoleHandler } from "@std/log/console-handler";
 import { isAbsolute } from "@std/path/is-absolute";
+import { fromSpecifier } from "@deno/media-type";
 import type { PluginData } from "./types.ts";
 import { Namespace } from "./constants.ts";
-import { memo } from "./utils.ts";
+import { mediaTypeToLoader, memo } from "./utils.ts";
 import { createResolve } from "./resolve.ts";
-import { loadDataURL, loadFileURL, loadHttpURL } from "./load.ts";
+import { loadFileURL, loadHttpURL } from "./load.ts";
 import { GlobalStrategy, LocalStrategy } from "./strategy.ts";
 import { resolveReferrer } from "./referrer.ts";
 import { existDir, existFile, readFile, realURL } from "./io.ts";
@@ -118,13 +119,49 @@ export function denoSpecifierPlugin(
       build.onResolve(
         { filter: /^data:/ },
         (args) => {
-          const referrer = resolveReferrer(args);
-          const { path: specifier, kind } = args;
+          const { path } = args;
 
-          return resolve(specifier, referrer, { kind });
+          const mediaType = fromSpecifier(path);
+
+          switch (mediaType) {
+            case "JavaScript":
+            case "JSX":
+            case "TypeScript":
+            case "TSX": {
+              return { path, namespace: "deno-data", pluginData: mediaType };
+            }
+
+            case "Json": {
+              throw new Error(
+                `Expected a JavaScript or TypeScript module, but identified a Json module. Consider importing Json modules with an import attribute with the type of "json".`,
+              );
+            }
+
+            case "Wasm": {
+              throw new Error(
+                `Expected a JavaScript or TypeScript module, but identified a Wasm module. Importing these types of modules is currently not supported.`,
+              );
+            }
+
+            default: {
+              throw new Error(
+                `Expected a JavaScript or TypeScript module, but identified a Unknown module. Importing these types of modules is currently not supported.`,
+              );
+            }
+          }
         },
       );
 
+      build.onLoad({ filter: /.*/, namespace: "deno-data" }, async (args) => {
+        const pluginData = args.pluginData as MediaType;
+
+        const response = await fetch(args.path);
+        const contents = await response.text();
+        const loader = mediaTypeToLoader(pluginData);
+
+        return { contents, loader };
+      });
+
       build.onResolve(
         { filter: /.*/, namespace: Namespace.DenoUrl },
         async (args) => {
@@ -155,9 +192,6 @@ export function denoSpecifierPlugin(
             case "file:":
               return loadFileURL(url, pluginData, readStrict, loader);
 
-            case "data:":
-              return loadDataURL(url, pluginData);
-
             default: {
               throw new Error("unsupported");
             }