fontawesome is referenced in icon.overrides, yet missing

[jhegg]

I think fontawesome was removed from the vendored bits, but was not replaced with the package dependency. Should it be?

[jhegg]

@cdaringe @eddier I'm not sure (or if) to fix this, any idea?

[cdaringe]

yea looks like it's missin!

i installed the npm package:

$ tree node_modules/font-awesome/fonts/
node_modules/font-awesome/fonts/
├── FontAwesome.otf
├── fontawesome-webfont.eot
├── fontawesome-webfont.svg
├── fontawesome-webfont.ttf
├── fontawesome-webfont.woff
└── fontawesome-webfont.woff2

@eddier, I dont recall what the import should look like. its not in site.overrides or icon.overrides. https://github.com/Tripwire/octagon/blob/master/semantic/src/themes/tripwire/globals/site.overrides . if you can advise as to what the font import statement is, i can update the build script?

[eddier]

I could be wrong, but doesnt SUI use their flavor of font that is in themes/tripwire/assets/fonts/ ? It should be labeled as icons.eot, svg, ttf,woff, woff2. When including the octagon lib you should be able to render a FA icon by using the syntax and it should work. Is it not?

[jhegg]

For example, user circle and user circle outline are just circles, and user outline is just a user. Here I'm using the following:

<Icon className='user plus' />
<Icon className='user circle' />
<Icon className='user circle outline' />
<Icon className='user outline' />
<Icon className='user' />
<Icon className='users' />

The rendered style should be i.icon.user.circle:before {}, and not i.icon.circle:before {}.

[eddier]

I think this may be a SUI issue rather than an issue with Octagon. Check out the example in their issues:
Semantic-Org/Semantic-UI-React#1371

[jhegg]

Got it. Closing for now. 😄

[cdaringe]

doh! thx :)