review feedback

[misterdjules]

/cc @trentm

Some where

"Somewhere"?

You need to be diligence

You need to be diligent

Because process.exit() isn't run in the typical case, you need to handle code
still executing.

It seems a bit unclear. I get what you mean but that's because we talked about
it face to face.

Stdout and stderr will (most likely) be flushed before exiting.

Does the "most likely" refers to the fact that it relies on libuv's
implementation details, and so that if (among other things) either:

1. the order with which libuv's event loop processes I/o and setImmediate
   changes

2. there are more than the limit of file descriptors for which events can be
   process in a single turn of the loop

are true, things might not work?

Actually, you're covering that later in the document, nevermind.

Because we are exiting, there is no special issue with the node event loop
blocking.

That's assuming nothing is scheduled to run on the event loop when exeunt is
called. If there are still active handles, it's not the case.

I think I've observed "The problem" when the node.js script is piped to some
other command. I don't know if this is because node.js will set stdout/stderr
blocking if they are a TTY.

Yes: nodejs/node@ab3306a

A (the?) node.js core issue related to this.

There are a lot (at least 10) of issues in nodejs/node related to this. One that
was aimed at tracking most of them was
nodejs/node#6980. However, some issues falling into
that topic were not equivalent. For instance, some were about TTYs only and
others were about pipes only.