Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to alter the language / localization of games and trophies? #242

Open
yduke opened this issue Jan 4, 2023 · 6 comments
Open

How to alter the language / localization of games and trophies? #242

yduke opened this issue Jan 4, 2023 · 6 comments
Labels

Comments

@yduke
Copy link

yduke commented Jan 4, 2023

Have well read the documents and didn't find how to change the local settings.

Is there any way to set what language the api return? Like es-es zh-cn zh-tw ?

Thank you.

@Ragowit
Copy link
Collaborator

Ragowit commented Jan 7, 2023

Don't know if there's an easy setting for it, but you could change a line in Client.php:

$guzzleOptions['headers']['Accept-Language'] = 'en-US';

Please note that it will not return language it doesn't have. If the game doesn't have any es-es languages, you can't get it. It will probably return en-US in that case. Or whatever Sony has said is the default for that title.

@yduke
Copy link
Author

yduke commented Jan 10, 2023

Thank you @Ragowit !
I've tried to modify the line you metioned above, and the tropies are localized!

But seems this is not effected the localizedName() under gameList(), for example:

foreach ($user->gameList() as $game) {
  $game->name();   //will return English name
  $game->localizedName();   //will return the same English name
  $game->concept()->shortDescription();  //will return localized short description
  $game->concept()->longDescription();  //will return localized long description
}

I am aware of some of games' name doesn't have a localized name, but I've tried alot and even successfully get the localized game name in $user->trophyTitles() foreach trophyTitle()->name() , so it means the game does have a localized name right?

Any idea on how to get localized name in gameList() ?

@Ragowit
Copy link
Collaborator

Ragowit commented Jan 10, 2023

I have actually no idea, maybe @Tustin knows more.

@Tustin
Copy link
Owner

Tustin commented Jan 10, 2023

I'd have to check the API again. Not sure if all the endpoints abide by that language header.

However, I'll make a change to allow passing a custom Accept-Language to the Client constructor.

@yduke
Copy link
Author

yduke commented Jan 11, 2023

Thank you both Ragowit and Tustin ! Respect!

A langrage parmeter for Client would be great, won't have to modify the mian files and better for update.

Cheers!

@stale
Copy link

stale bot commented Apr 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants