Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish docker image to dockerhub and github packages using a github action #45

Open
marcindulak opened this issue May 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@marcindulak
Copy link
Contributor

marcindulak commented May 10, 2024

Due to heavy dependencies (puppeteer + google chrome) the common usage of linspector will be most likely using a pre-built docker image, to minimize the risk of component installation failures, and increase the installation speed. Also pre-commit hooks will probably be of repository-local-hooks (calling a docker run) or docker_image type.

Publish docker image as umbrelladocs/linkspector. See publishing-docker-images as a starting point. Note the artifact attestation step included in the above doc. For covenience, most likely the latest explicit image tag of umbrelladocs/linkspector, e.g. v0.3.6 will be also pushed as the latest docker image tag. This will allow people who prefer to use the latest version to refer to umbrelladocs/linkspector:latest from CI systems.

Another observation: currently the docker build uses a non-standard default (requires --build-arg LINKSPECTOR_PACKAGE=) to build the image based on the local contents. This default could be changed in Dockerfile, so by default the local contents is used during the build

docker build --no-cache --pull -t umbrelladocs/linkspector .

while still support building of published npm

docker build --build-arg LINKSPECTOR_VERSION=@umbrelladocs/linkspector@0.2.7 -t umbrelladocs/linkspector:0.2.7 .

This is also an opportunity to reduce the confusion between potentially different 0.2.7 and v0.2.7 versions used by various services: npm, github, dockerhub.

@gaurav-nelson gaurav-nelson added the enhancement New feature or request label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants