Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conda-forge build test failure #2551

Closed
dopplershift opened this issue Nov 8, 2022 · 2 comments
Closed

conda-forge build test failure #2551

dopplershift opened this issue Nov 8, 2022 · 2 comments
Labels
area/tests
Milestone
4.9.1

Comments

@dopplershift
Copy link
Member

Running down a test failure in conda-forge/libnetcdf-feedstock#154, ncdump/tst_bom.sh and ncdump/tst_nccopy4.sh failed, with odd diffs. They were running concurrently, and it turns out the problem is that both test scripts write temporary output to tmp.cdl.

I'll also note that tmp.cdl is mentioned in ncdump/run_back_comp_tests.sh (but commented out). The file is also removed (but not created?) in ncdump/tst_nccopy5.sh.

There are also some occurrences in nczarr_test/run_nccopyz.sh and nczarr_test/run_nczarr_fill.sh. I'm not sure if that's potentially problematic or not.
@dopplershift dopplershift added this to the 4.9.1 milestone Nov 8, 2022
@dopplershift dopplershift mentioned this issue Nov 8, 2022
Merged
5 tasks
@DennisHeimbigner
Copy link
Collaborator

I knew there was a race condition in some of our tests, but never
got around to tracking the cause. Thanks. I will submit a PR.n

DennisHeimbigner added a commit to DennisHeimbigner/netcdf-c that referenced this issue Nov 9, 2022
@DennisHeimbigner
Fix race condition in ncdump (and other) tests.
9f848c9 
re: Issue Unidata#2551

Ryan May identified the use of a common scratch file (tmp.cdl)
across multiple test shell scripts in ncdump directory
and the nczarr_test directory.
This sometimes causes errors because of race conditions
between those scripts.

I renamed those common files to avoid the race condition.  I
also did some further checking and found some additional,
similar conflicts and fixed those. Also did some minor cleanup
of unused files.

Tests fixed:
ncdump: run_back_comp_tests.sh tst_bom.sh tst_nccopy4.sh tst_nccopy5.sh
nczarr_test: git df master -- run_nccopyz.sh run_nczarr_fill.sh run_scalar.sh
@DennisHeimbigner DennisHeimbigner mentioned this issue Nov 9, 2022
Merged
@dopplershift
Copy link
Member Author

Closing because the tests mentioned here are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests
Projects
None yet
Milestone
4.9.1
Development

No branches or pull requests
2 participants
@dopplershift @DennisHeimbigner