Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more unit tests #1472

Merged
merged 31 commits into from
Aug 22, 2019
Merged

more unit tests #1472

merged 31 commits into from
Aug 22, 2019

Conversation

edhartnett
Copy link
Contributor

@edhartnett edhartnett commented Aug 21, 2019 •
edited
Loading

Part of #1458.
Part of #1457

Adding more unit tests, this time for the code in nc4internal.c. (These unit tests run for netcdf-4 builds.)

More coming.

This includes PR #1463 and #1464.

@edhartnett
whitespace cleanup
fb32957
@edhartnett
starting to add doxygen docs for nclistmgr.c
916802b
@edhartnett
documented functions in nclistmgr.c
d558873
@edhartnett
starting to add unit tests
298136a
@edhartnett
working on nclistmgr tests
c8e8558
@edhartnett
more documentation
f20db2e
@edhartnett
more tests for nclistmgr.c
3eacf94
@edhartnett
more testing of nclistmgr.c
8b8ece4
@edhartnett
more testing, sorting out some memory issues in test
d76114a
@edhartnett
removed unnecessary checking in find_in_NCList()
821b749
@edhartnett
more comments
88077fe
@edhartnett
only run slow nclist test if --enable-large-file-tests is used
978707c
@edhartnett
fixed missing dependency in unit_test Makefile.am
f007523
@edhartnett
cleaned up Makefile.am
c2d2c9d
@edhartnett
documentation
dce6f32
@edhartnett
fixed Makefile.am
26020e2
@edhartnett
starting to remove obsolete _CRAYMPP macros
60f436e
@edhartnett
more removal of obsolete _CRAYMPP macro
06d700d
@edhartnett
removed _CRAYMPP from manpage
822b5f6
@edhartnett
removed rest of LOCKNUMREC and _CRAYMPP obsolete macros
c7e022f
@edhartnett
Merge branch 'master' into ejh_next
bce3fa6
@edhartnett
added 2019 to netcdf.h copyright notice
fb371d3
@edhartnett
more unit tests, this time for nc4internal.c
e4ef7b1
@edhartnett
more comments
0e95d4c
@edhartnett
run tst_nc4internal for netcdf4 builds only
9634463
@edhartnett
more unit testing
bf069c3
@edhartnett
more unit testing
788c63d
@edhartnett
more unit testing
e9cc0e2
@edhartnett
more unit tests for nc4internal functions
04544a3
@edhartnett
more unit tests for nc4internal.c
5f586fc
@edhartnett edhartnett requested a review from WardF as a code owner August 21, 2019 19:40
@WardF WardF self-assigned this Aug 21, 2019
@WardF WardF added this to the 4.7.1 milestone Aug 21, 2019
WardF
WardF approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@WardF WardF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; I'm going to pull to a local branch and add the equivalent scaffolding for unit tests to CMake, with guards against running it via Visual Studio (until I get that sorted out).

@WardF WardF mentioned this pull request Aug 21, 2019
Merged
@edhartnett edhartnett mentioned this pull request Aug 22, 2019
Merged
@WardF WardF merged commit 100e000 into Unidata:master Aug 22, 2019
@edhartnett edhartnett deleted the ejh_move_ncid_2 branch September 3, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WardF WardF WardF approved these changes

Assignees

@WardF WardF

Labels
area/tests
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@edhartnett @WardF