Allow use of type keywords as identifiers in some formats #1753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt that type. Built-in type-name keywords are currently flagged when used as identifiers in formats that do not support that type. So if a user declares a dimension named "string" in a classic .cdl file, it causes an error. This PR modifies ncgen to allow those format-specific type keywords to be used as identifiers when compiling to formats that do not support that type. Also added a test for this. Also a couple of misc. changes to conditionalize some debug output.
DennisHeimbigner
added a commit
to DennisHeimbigner/netcdf-c
that referenced
this pull request
Apr 13, 2021
re: Unidata#1977 PR Unidata#1753, changed ncgen to allows certain type names to be used as identifiers in selected situations. An unwanted side effect was that existing type aliases no longer were accepted by ncgen. Specifically, using the "long" type caused an error. I was able to figure out a better solution to the original problem (Unidata#1750) that also fixes this problem as well. This PR fixes that problem in ncgen/ncgen.l, and adds tests to ncdump/test_keywords.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re: #1750
Built-in type-name keywords are currently flagged when used as
identifiers in formats that do not support that type. So if a
user declares a dimension named "string" in a classic .cdl file,
it causes an error.
This PR modifies ncgen to allow those format-specific type keywords
to be used as identifiers when compiling to formats that do not
support that type. Also added a test for this.
Also a couple of misc. changes to conditional-ize some debug output.