Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display "No Data To Display" On JupTables When There's No Rows #187

Open
outragedhuman opened this issue Feb 8, 2023 · 1 comment · Fixed by #190
Open

Display "No Data To Display" On JupTables When There's No Rows #187

outragedhuman opened this issue Feb 8, 2023 · 1 comment · Fixed by #190
Labels
Beta Feedback from users during the beta testing period. enhancement New feature or request required4delivery Delivery cannot be made without this issue being addressed.

Comments

@outragedhuman
Copy link
Collaborator

When a JupTable component is passed an empty array of rows, it should render out a default row that indicates "No data to display". This way the user doesn't just see an empty table.

Bonus points if this could include specific text:

  • "You don't currently own any assets."
  • "You haven't sent or recieved any transactions yet."
  • "No trades to display"

This could be accomplished by passing in a "defaultRow" component or text and rendering this conditionally when rows are empty.
@outragedhuman outragedhuman added enhancement New feature or request required4delivery Delivery cannot be made without this issue being addressed. Beta Feedback from users during the beta testing period. labels Feb 8, 2023
@outragedhuman
Copy link
Collaborator Author

This could also be an optional prop so if it's not passed then a generic default is displayed.

@outragedhuman outragedhuman mentioned this issue Feb 12, 2023
Merged
4 tasks
@outragedhuman outragedhuman linked a pull request Feb 12, 2023 that will close this issue
Display Placeholder Row in JUPTable When No Row Data Exists #190
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Beta Feedback from users during the beta testing period. enhancement New feature or request required4delivery Delivery cannot be made without this issue being addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display Placeholder Row in JUPTable When No Row Data Exists Up-North-Coding/jovian
1 participant
@outragedhuman