From 1201f979cd7a83df2d6a0b200f56072fe70e0ae9 Mon Sep 17 00:00:00 2001 From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com> Date: Thu, 7 Apr 2022 11:50:51 -0300 Subject: [PATCH] refactor: Removes the CSS files from the Partition plugin (#19521) * refactor: Removes the CSS files from the Partition plugin * Fixes bullet * Always use the color of the partitions --- .../package.json | 3 - .../src/Partition.css | 64 --------------- .../src/Partition.js | 4 +- .../src/ReactPartition.js | 22 ----- .../src/ReactPartition.jsx | 81 +++++++++++++++++++ 5 files changed, 82 insertions(+), 92 deletions(-) delete mode 100644 superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.css delete mode 100644 superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.js create mode 100644 superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.jsx diff --git a/superset-frontend/plugins/legacy-plugin-chart-partition/package.json b/superset-frontend/plugins/legacy-plugin-chart-partition/package.json index 54c95b3e9496b..2384214fd9fe8 100644 --- a/superset-frontend/plugins/legacy-plugin-chart-partition/package.json +++ b/superset-frontend/plugins/legacy-plugin-chart-partition/package.json @@ -15,9 +15,6 @@ }, "license": "Apache-2.0", "author": "Superset", - "sideEffects": [ - "*.css" - ], "main": "lib/index.js", "module": "esm/index.js", "files": [ diff --git a/superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.css b/superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.css deleted file mode 100644 index 4fce2089b93ff..0000000000000 --- a/superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.css +++ /dev/null @@ -1,64 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -.superset-legacy-chart-partition { - position: relative; -} - -.superset-legacy-chart-partition .chart { - display: block; - margin: auto; - font-size: 11px; -} - -.superset-legacy-chart-partition rect { - stroke: #eee; - fill: #aaa; - fill-opacity: 0.8; - transition: fill-opacity 180ms linear; - cursor: pointer; -} - -.superset-legacy-chart-partition rect:hover { - fill-opacity: 1; -} - -.superset-legacy-chart-partition g text { - font-weight: bold; - fill: rgba(0, 0, 0, 0.8); -} - -.superset-legacy-chart-partition g:hover text { - fill: rgba(0, 0, 0, 1); -} - -.superset-legacy-chart-partition .partition-tooltip { - position: absolute; - top: 0; - left: 0; - opacity: 0; - padding: 5px; - pointer-events: none; - background-color: rgba(255, 255, 255, 0.75); - border-radius: 5px; -} - -.partition-tooltip td { - padding-left: 5px; - font-size: 11px; -} diff --git a/superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js b/superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js index 5355530cd536a..22470616680bc 100644 --- a/superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js +++ b/superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js @@ -26,7 +26,6 @@ import { getTimeFormatter, CategoricalColorNamespace, } from '@superset-ui/core'; -import './Partition.css'; // Compute dx, dy, x, y for each node and // return an array of nodes in breadth-first order @@ -268,13 +267,12 @@ function Icicle(element, props) { if (useRichTooltip) { const nodes = getAncestors(d); nodes.reverse().forEach(n => { - const atNode = n.depth === d.depth; t += ''; t += '' + '' + '
' + '' + diff --git a/superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.js b/superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.js deleted file mode 100644 index 22d61a6c88e71..0000000000000 --- a/superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.js +++ /dev/null @@ -1,22 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -import { reactify } from '@superset-ui/core'; -import Component from './Partition'; - -export default reactify(Component); diff --git a/superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.jsx b/superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.jsx new file mode 100644 index 0000000000000..d73476ac58f9f --- /dev/null +++ b/superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.jsx @@ -0,0 +1,81 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import { reactify, styled } from '@superset-ui/core'; +import Component from './Partition'; + +const ReactComponent = reactify(Component); + +const Partition = ({ className, ...otherProps }) => ( +
+ +
+); + +export default styled(Partition)` + ${({ theme }) => ` + .superset-legacy-chart-partition { + position: relative; + } + + .superset-legacy-chart-partition .chart { + display: block; + margin: auto; + font-size: ${theme.typography.sizes.s}px; + } + + .superset-legacy-chart-partition rect { + stroke: ${theme.colors.grayscale.light2}; + fill: ${theme.colors.grayscale.light1}; + fill-opacity: ${theme.opacity.heavy}; + transition: fill-opacity 180ms linear; + cursor: pointer; + } + + .superset-legacy-chart-partition rect:hover { + fill-opacity: 1; + } + + .superset-legacy-chart-partition g text { + font-weight: ${theme.typography.weights.bold}; + fill: ${theme.colors.grayscale.dark1}; + } + + .superset-legacy-chart-partition g:hover text { + fill: ${theme.colors.grayscale.dark2}; + } + + .superset-legacy-chart-partition .partition-tooltip { + position: absolute; + top: 0; + left: 0; + opacity: 0; + padding: ${theme.gridUnit}px; + pointer-events: none; + background-color: ${theme.colors.grayscale.dark2}; + border-radius: ${theme.gridUnit}px; + } + + .partition-tooltip td { + padding-left: ${theme.gridUnit}px; + font-size: ${theme.typography.sizes.s}px; + color: ${theme.colors.grayscale.light5}; + } + `} +`;