Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are you ready for Valve Index? (1070910) #2616

Open
2 tasks done
Scrumplex opened this issue Apr 30, 2019 · 28 comments
Open
2 tasks done

Are you ready for Valve Index? (1070910) #2616

Scrumplex opened this issue Apr 30, 2019 · 28 comments
Labels
Game compatibility - Unofficial Games not expected to work without issues

Comments

@Scrumplex
Copy link

Compatibility Report

  • Name of the tool with compatibility issues: Are you ready for Valve Index?
  • Steam AppID of the tool: 1070910

System Information

I confirm:

  • that I haven't found an existing compatibility report for this game.
  • that I have checked whether there are updates for my system available.

steam-1070910.log

Symptoms

Crashes while checking

Reproduction

Click on the check system button.

@kisak-valve kisak-valve added the Game compatibility - Unofficial Games not expected to work without issues label Apr 30, 2019
@kisak-valve
Copy link
Member

Unhandled exception: unimplemented function ADVAPI32.dll.EventWriteString called in 32-bit code (0x7bc57021).

@Vash63
Copy link

Vash63 commented Apr 30, 2019

Can duplicate on Arch w/ Nvidia 430.09. Gist: https://gist.github.com/Vash63/2b0bf8495f95385ab2304551e43d8928

@Scrumplex
Copy link
Author

@kisak-valve is this really Game compatibility - Unofficial? It is official Valve Software, that claims to be available on Linux

@kisak-valve
Copy link
Member

Any game or app run with Proton that has not been whitelisted falls into this general category.

@davidak
Copy link

davidak commented Apr 30, 2019

@Scrumplex there is a hint in the description of the app, that it is not compatible with linux, but valve index is.

So i'm wondering why it was not developed plattform independent in the first place?

This seems to be a simple program. Can you please release it under an open source license on github?

@Scrumplex
Copy link
Author

1556655715

Reading this, I assumed that this tool would be compatible, too.

@davidak
Copy link

davidak commented Apr 30, 2019

@Scrumplex Yeah, that's a bit misleading. See the tools store page:

Screenshot from 2019-04-30 22-31-34

@Evernow
Copy link

Evernow commented May 1, 2019

Can confirm I also just crash when checking. My system also meets the minimum requirements: https://gist.github.com/Evernow/16a6f98a39f4a3ddf117f5417b708b4c

@julienbenjamin
Copy link

I can confirm as well it crashes on latest Debian stable.

@ryao
Copy link

ryao commented Aug 18, 2019

I wrote the following patch, which might fix this, but I am not setup to build proton to be able to test it at the moment:

https://cdn.discordapp.com/attachments/500324802255650816/612507625460072469/wine-Add-EventWriteString-stub.patch

I don't know when I'll do my first proton build to test it. I am linking it here in case anyone wants to try.

@ryao
Copy link

ryao commented Aug 18, 2019

I tested the patch by:

  1. Dropping it into /etc/portage/patches/app-emulation/wine-vanilla-9999 on Gentoo Linux.
  2. Running EGIT_OVERRIDE_REPO_WINE=https://github.com/ValveSoftware/wine.git EGIT_OVERRIDE_BRANCH_WINE=proton_4.11 EGIT_OVERRIDE_COMMIT_WINE=aebdb22bb57128a5f38cd07d3952f1eb62e44817 ebuild $(equery which -m app-emulation/wine-vanilla) compile
  3. Copying /var/tmp/portage/app-emulation/wine-vanilla-9999/work/wine-9999-abi_x86_32.x86/dlls/advapi32/advapi32.dll.so to ${HOME}/.local/share/Steam/steamapps/common/Proton 4.11/dist/lib/wine/advapi32.dll.so to replace the stock proton version.
  4. Running Are you ready for Valve Index?.

Here is the result:

image

I will send the patch to the wine developers later. I will open a pull request for ValveSoftware/Wine when I do.

@ryao
Copy link

ryao commented Aug 18, 2019

steam-1070910.log

Also, here is the proton log from the patched proton 4.11-2.

@ryao
Copy link

ryao commented Aug 18, 2019

I have opened a pull request with the patch. I have also submitted (a rebased version) to upstream wine.

@ryao
Copy link

ryao commented Aug 20, 2019

The patch is now in Wine:

wine-mirror/wine@8d55542

If it is not in a backport to proton 4.11, it will be in the next proton branch. However, I have been told in IRC that a backport was likely after it was merged to wine. Hopefully, this will be fixed in proton 4.11-3.

@ryao
Copy link

ryao commented Aug 20, 2019

It is confirmed that this will be fixed in Proton 4.11-3:

ValveSoftware/wine#63 (comment)

@ryao
Copy link

ryao commented Aug 20, 2019

@kisak-valve Would you be willing to mark this issue fixed after proton 4.11-3 is released so that a new issue could be filed for the USB 3.0 detection bug that the original crashing issue hid? It would be nice to clean up the tracker by letting a new issue track the USB 3.0 detection problem.

@ryao
Copy link

ryao commented Aug 27, 2019

@kisak-valve My patch got pulled into the repository in time for the Proton 4.11-3 release:

https://github.com/ValveSoftware/wine/commits/proton_4.11

I can confirm that the crash issue is fixed now.

@davidak
Copy link

davidak commented Oct 29, 2019

It crashes again with Proton 4.11-7 on my Thinkpad with i5 integrated GPU.

https://gist.github.com/davidak/00772774092a2b7364d46f0e734670c2

Can you reproduce this? Maybe it's just intel graphics and not with dedicated gpus?

@kisak-valve
Copy link
Member

Hello @davidak, wine: Call from 0x7bc77ee9 to unimplemented function ADVAPI32.dll.EventWriteString, aborting looks like the line of interest from your log.

@aeikum
Copy link
Collaborator

aeikum commented Oct 29, 2019

My mistake. Will fix in the next release.

@aeikum aeikum added this to the Next Release milestone Oct 29, 2019
@aeikum
Copy link
Collaborator

aeikum commented Nov 8, 2019

Should be working again in 4.11-8.

@aeikum aeikum removed this from the Next Release milestone Nov 8, 2019
@OvermindDL1

This comment has been minimized.

@OvermindDL1

This comment has been minimized.

@kisak-valve

This comment has been minimized.

@OvermindDL1

This comment has been minimized.

@kisak-valve

This comment has been minimized.

@OvermindDL1

This comment has been minimized.

@davidak
Copy link

davidak commented Aug 8, 2021

The game starts and runs now, but does not work correctly.

Screenshot from 2021-08-08 04-56-18

The OS is NixOS 21.11 (Beta), the RAM is 32 GB + 32 GB SWAP, the CPU has 8 cores + hyperthreading (i9), the GPU is actually called AMD RX 480 und the system actually has USB 3. So each value could be more specific.

Screenshot from 2021-08-08 05-12-44

And the Valve Index works great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game compatibility - Unofficial Games not expected to work without issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants