fix ping handling

VladBrok · Sep 30, 2023 · 917ec38 · 917ec38
1 parent 9df4f4c
commit 917ec38
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/api/helpers/handle-utterance.ts b/api/helpers/handle-utterance.ts
@@ -23,7 +23,6 @@ export default async function handleUtterance(
   const isUpdateTask = intents?.["update_task"];
   const isGetExpired = intents?.["get_expired"];
   const isHelp = intents?.["help"];
-  const isPing = body.request.original_utterance.trim() === "ping"; // https://yandex.ru/dev/dialogs/alice/doc/moderation.html#check-after-moderation
   let responseText = t("unhandle_utterance");
   let responseTts = "";
 
@@ -205,8 +204,6 @@ export default async function handleUtterance(
   } else if (isHelp) {
     responseText = t("help");
     responseTts = applyTts(responseText);
-  } else if (isPing) {
-    responseText = "pong";
   }
 
   const answer: ResBody = {

diff --git a/api/index.ts b/api/index.ts
@@ -8,6 +8,7 @@ import greetKnownUser from "./helpers/greet-known-user";
 import greetNewUser from "./helpers/greet-new-user";
 import handleError from "./helpers/handle-error";
 import { initICU } from "./helpers/icu";
+import end from "./helpers/end-response";
 
 async function handler(req: VercelRequest, res: VercelResponse) {
   if (req.method !== "POST") {
@@ -18,6 +19,19 @@ async function handler(req: VercelRequest, res: VercelResponse) {
 
   const body = req?.body as ReqBody;
   try {
+    // https://yandex.ru/dev/dialogs/alice/doc/moderation.html#check-after-moderation
+    const isPing = body.request.original_utterance.trim() === "ping";
+    if (isPing) {
+      end(res, {
+        version: body.version,
+        response: {
+          text: "pong",
+          end_session: false,
+        },
+      });
+      return;
+    }
+
     await initICU();
 
     const supportsAuth = Boolean(body.meta.interfaces.account_linking);