Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(AddComponentButtonComponent): Improve test #1545

Open
geoffreykwan opened this issue Nov 30, 2023 · 0 comments
Open

test(AddComponentButtonComponent): Improve test #1545

geoffreykwan opened this issue Nov 30, 2023 · 0 comments

Comments

@geoffreykwan
Copy link
Member

The test in add-component-button.component.spec.ts is misleading because it makes it sound like clicking on the button will open the dialog, create the component, and save the project. In actuality, clicking the button will only open the dialog. It might be better to separate it into two tests. One tests opening the dialog and another tests when the dialog is closed, it creates the component and saves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant