Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when building angular 12 library with asyncapi-validator included #64

Open
davyvanlaere opened this issue Jun 24, 2024 · 1 comment

Comments

@davyvanlaere
Copy link

davyvanlaere commented Jun 24, 2024

Building an angular 12 application with this library included fails:

`
./node_modules/@apidevtools/json-schema-ref-parser/lib/resolvers/http.js:3:13-28 - Error: Module not found: Error: Can't resolve 'http' in 'C:\Git\myproject\node_modules@apidevtools\json-schema-ref-parser\lib\resolvers'
Did you mean './http'?
Requests that should resolve in the current directory need to start with './'.
Requests that start with a name are treated as module requests and resolve within module directories (C:/Git/myproject, node_modules).
If changing the source code is not an option there is also a resolve options called 'preferRelative' which tries to resolve these kind of requests in the current directory too.

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
- add a fallback 'resolve.fallback: { "http": require.resolve("stream-http") }'
- install 'stream-http'
If you don't want to include a polyfill, you can use an empty module like this:
resolve.fallback: { "http": false }

./node_modules/@apidevtools/json-schema-ref-parser/lib/resolvers/http.js:4:14-30 - Error: Module not found: Error: Can't resolve 'https' in 'C:\Git\myproject\node_modules@apidevtools\json-schema-ref-parser\lib\resolvers'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
- add a fallback 'resolve.fallback: { "https": require.resolve("https-browserify") }'
- install 'https-browserify'
If you don't want to include a polyfill, you can use an empty module like this:
resolve.fallback: { "https": false }

./node_modules/asyncapi-validator/src/Parser.js:7:27-49 - Error: Module not found: Error: Can't resolve 'fs' in 'C:\Git\myproject\node_modules\asyncapi-validator\src'
`

http and https were fixed by this piece of configuration:

{ "compilerOptions": { "paths": { "http": [ "./node_modules/stream-http" ], "https": [ "./node_modules/https-browserify" ] } } }

@davyvanlaere davyvanlaere changed the title Angular 12 issue Issue when building angular 12 library with asyncapi-validator included Jun 24, 2024
@WaleedAshraf
Copy link
Owner

@davyvanlaere, I guess your issue was fixed using compilerOptions. right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants