Fix bugs related to a deadlock, and iOS 16 Deprecations #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMostfa
commented
Apr 4, 2024
Comment on lines
+5472
to
+5474
| // r1 = CFReadStreamSetProperty(readStream4, kCFStreamNetworkServiceType, kCFStreamNetworkServiceTypeBackground); | ||
| // r2 = CFWriteStreamSetProperty(writeStream4, kCFStreamNetworkServiceType, kCFStreamNetworkServiceTypeBackground); | ||
| // |
There was a problem hiding this comment.
yes, it's commented code in the source file of lib.
bitomule
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yesterday i updated CocoaAsyncSocket to the latest version, hoping that it's going to fix bugs, we were on 7.5.1 and now we are 7.6.5
while diffing both version, and checking the release notes, they said that they fixed some bugs, but they appeared to not be related to us, so i did more search to find a very, smart Chinese blog discussing similar issues
and here we do the implementation they described in Chinese
https://it-wallapop.sentry.io/issues/4984384977/?query=is%3Aunresolved+closeWithError&referrer=issue-stream&statsPeriod=90d&stream_index=0&utc=true
now it's important to know that we have tons of bugs coming from ths lib, which is powering the xmpp framework, so trying to fix it, and update it, should be a good idea.