Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eslint github action #280

Open
ann-kilzer opened this issue Oct 9, 2022 · 3 comments
Open

Fix Eslint github action #280

ann-kilzer opened this issue Oct 9, 2022 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ann-kilzer
Copy link
Collaborator

ann-kilzer commented Oct 9, 2022

Describe the bug
The Github actions are failing... maybe the plugin is old?

To Reproduce
Steps to reproduce the behavior:

  1. Go to the PRs
  2. Click on a PR
  3. Scroll down to the checks and see the failed check
  4. See an error on hallee/eslint https://github.com/WWCodeTokyo/speak-her-db/actions/runs/3214168172/jobs/5254367000

Expected behavior
Eslint check should run

Screenshots

@ann-kilzer ann-kilzer added the bug Something isn't working label Oct 9, 2022
@ann-kilzer
Copy link
Collaborator Author

hallee/eslint is deprecated in favor of https://github.com/actions/toolkit/blob/master/docs/problem-matchers.md

@ann-kilzer ann-kilzer self-assigned this Oct 11, 2022
@ann-kilzer ann-kilzer added the help wanted Extra attention is needed label Oct 18, 2022
@ann-kilzer ann-kilzer removed their assignment Oct 18, 2022
@ann-kilzer
Copy link
Collaborator Author

I removed hallee/eslint but still see a failed eslint check. Is this some netlify thing? I can't figure out how to turn it off

@RageZBla
Copy link
Collaborator

@ann-kilzer should we close this issue or do you still want to use eslint at some point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants