-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.0.0 #1388
Comments
|
I think that more research needs to be done before a decision can be made on it. I will not have time to look into it in before 1.0.0 is released. I suggest punting, unless somebody else wants to take it over, or there is a minimal approach.
Nobody has expressed a strong opinion on it, so maybe it isn't worth the change. It really depends on how the sniff might evolve in the future (whether a second sniff will be introduced or this one will be changed to have the option to just catch low-hanging fruit), and I cannot predict/commit to that. |
FYI: I'll get back to this on Thursday. Only a few more things left to do before we're ready to release. |
Status update:The release will close end of the week.
|
Status update:All relevant open issues have been resolved, all PRs which were still needed for the 1.0.0 release have been merged. Some things - like the fix for PHPCS annotations for the Providing I get at least one more approval for the release PR #1392, I will release WPCS 1.0.0 tomorrow (Wednesday July 25th UTC). |
And... the release is out: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/releases/tag/1.0.0 |
Release tweet: https://twitter.com/jrf_nl/status/1022186349355585536 |
Well done everyone, particularly @jrfnl :-) |
Looking at the milestone, it's about time we release version 1.0.0 (understatement intended).
Proposed target release date: Monday July 2nd.
I also think that it may be a good idea to do more regular (smaller) releases.
There are a couple of open issues/PRs which I'd like to see finished/merged before then:
AlternativeFunctions: improve handling of file_get_contents() #1374,ArrayIndentation: fix fixer conflict with multi-line trailing comments #1384,Sniff::$printingFunctions / EscapeOutput: fix words being misidentified as language constructs #1386,Sniff::get_function_call_parameters(): correctly handle closures when passed as param #1387are IMO all good to go & ready to mergeIf @moorscode does not have time this week, this sniff can be moved to the 1.1.0 release.
Update: review done, minor changes requested.
If not, this sniff can be moved to the 1.1.0 release.
exclude
property toarray
#1368 -I will open a PR for this shortlyPR Abstracts: change $exclude property from string to array #1390 addresses this.Update: PR PHPCS cross-version compatibility: account for the new PHPCS native whitelist comments #1407 takes care of the majority of this. Second PR upcoming.
volunteers welcome, if needs be, I can probably do this myself sometime this weekI'm working on this.Opinions ? Additions ?
/cc @WordPress-Coding-Standards/wpcs-admins
The text was updated successfully, but these errors were encountered: