Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing of version 2.0.0 #1389

Closed
jrfnl opened this issue Jun 25, 2018 · 5 comments
Closed

Timing of version 2.0.0 #1389

jrfnl opened this issue Jun 25, 2018 · 5 comments

Comments

@jrfnl
Copy link
Member

jrfnl commented Jun 25, 2018

I previously proposed to drop PHPCS 2.x support and remove all deprecated sniffs by end of August - largely with an eye on being able to have a different namespace to prevent clashes with the WP project itself.

I'd like to propose changing that deadline to end of December 2018 for the following reasons:

  1. WPCS 1.0.0 deprecates a number of sniffs which we'd want to remove in v 2.0.0.
  2. WPCS 1.0.0 contains breaking changes, most notably the re-categorization of a number of sniffs.
  3. At this moment, it doesn't look like WP Core will drop PHP 5.2/start using namespaces within the next six months, so the namespace reason is less urgent.

As there are numerous standards out there which have WPCS as a dependency, we ought to allow them some time to adjust their standard. and two (summer/vacation) months does not really sound long enough, which is why I'm proposing moving the 2.0.0 release back to the end of the year.

Opinions ?

/cc @WordPress-Coding-Standards/wpcs-admins

@jrfnl
Copy link
Member Author

jrfnl commented Dec 17, 2018

FYI: I've prepared most of the changes needed for WPCS 2.0.0.
Once WPCS 1.2.1 is out of the door tomorrow, I will start pulling commits cherrypicked from my WIP branch. Expect something like 30 to 40 PRs to get all the changes in.

@GaryJones
Copy link
Member

After some discussion, @jrfnl and I plan to do a 2.0.0-RC release in the middle of next week, once the change log is done (most of the 2.0.0 code changes are now done), and then follow that up with a 2.0.0 release in early to mid January.

@jrfnl
Copy link
Member Author

jrfnl commented Dec 25, 2018

FYI: I've trailed through all the PHPCS 3.x changelogs up to 3.4.0 for any other changes WPCS could benefit from and opened issues/PRs for what remained. Aside from the changelog and some minor documentation updates (and the currently open PRs), as far as I'm concerned WPCS 2.0.0 is done.

Might be worth it to have a look at the older open PRs to see if any of them can go in and to trail through open issues to see if there are any which can be closed (or addressed as quick wins).

@jrfnl
Copy link
Member Author

jrfnl commented Dec 30, 2018

@jrfnl jrfnl mentioned this issue Jan 14, 2019
10 tasks
@jrfnl jrfnl closed this as completed Jan 16, 2019
@jrfnl
Copy link
Member Author

jrfnl commented Jan 16, 2019

WPCS 2.0.0 has been released: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/releases/tag/2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants