From 28fcb77892770a7915db3d83f78a01ef7d0450ae Mon Sep 17 00:00:00 2001 From: Jorge Costa Date: Fri, 9 Aug 2024 17:06:10 +0100 Subject: [PATCH] improve count labels --- .../dataviews-bulk-actions/index.tsx | 24 ++++++++++++------- 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/packages/dataviews/src/components/dataviews-bulk-actions/index.tsx b/packages/dataviews/src/components/dataviews-bulk-actions/index.tsx index abea0179bf35c..b2dc4289814a6 100644 --- a/packages/dataviews/src/components/dataviews-bulk-actions/index.tsx +++ b/packages/dataviews/src/components/dataviews-bulk-actions/index.tsx @@ -192,10 +192,22 @@ function renderFooterContent< Item >( onChangeSelection: SetSelection, selectableItems: Item[] ) { - const countToShow = + const message = selectedItems.length > 0 - ? selectedItems.length - : selectableItems.length; + ? sprintf( + /* translators: %d: number of items. */ + _n( + '%d Item selected', + '%d Items selected', + selectedItems.length + ), + selectedItems.length + ) + : sprintf( + /* translators: %d: number of items. */ + _n( '%d Item', '%d Items', data.length ), + data.length + ); return ( ( getItemId={ getItemId } /> - { sprintf( - /* translators: %d: number of items. */ - _n( '%d Item', '%d Items', countToShow ), - countToShow - ) } + { message }