Filter counter: only count filters that actually have a value applied

WordPress · Dec 13, 2023 · 8482576 · 8482576
1 parent cd2b253
commit 8482576
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/packages/dataviews/src/add-filter.js b/packages/dataviews/src/add-filter.js
@@ -41,6 +41,13 @@ export default function AddFilter( { filters, view, onChangeView } ) {
 		return null;
 	}
 
+	const filterCount = view.filters.reduce( ( acc, filter ) => {
+		if ( filter.value !== undefined ) {
+			return acc + 1;
+		}
+		return acc;
+	}, 0 );
+
 	return (
 		<DropdownMenu
 			label={ __( 'Filters' ) }
@@ -53,9 +60,9 @@ export default function AddFilter( { filters, view, onChangeView } ) {
 					icon={ funnel }
 					className="dataviews-filters-button"
 				>
-					{ view.type === LAYOUT_LIST && view.filters.length > 0 ? (
+					{ view.type === LAYOUT_LIST && filterCount > 0 ? (
 						<span className="dataviews-filters-count">
-							{ view.filters.length }
+							{ filterCount }
 						</span>
 					) : null }
 				</Button>