From dc147f6802a218f0ca27117282697eea4e595076 Mon Sep 17 00:00:00 2001
From: scruffian <ben@scruffian.com>
Date: Tue, 4 Jul 2023 13:47:14 +0100
Subject: [PATCH] remove permissions from the useSelect

---
 .../src/navigation/use-navigation-menu.js     | 41 +++++++------------
 1 file changed, 15 insertions(+), 26 deletions(-)

diff --git a/packages/block-library/src/navigation/use-navigation-menu.js b/packages/block-library/src/navigation/use-navigation-menu.js
index 26f5bae0fd4e1..9ee8ac2e9072a 100644
--- a/packages/block-library/src/navigation/use-navigation-menu.js
+++ b/packages/block-library/src/navigation/use-navigation-menu.js
@@ -18,14 +18,6 @@ export default function useNavigationMenu( ref ) {
 
 	const useSelectResult = useSelect(
 		( select ) => {
-			const {
-				canCreate,
-				canUpdate,
-				canDelete,
-				isResolving,
-				hasResolved,
-			} = permissions;
-
 			const {
 				navigationMenu,
 				isNavigationMenuResolved,
@@ -36,44 +28,41 @@ export default function useNavigationMenu( ref ) {
 				navigationMenu,
 				isNavigationMenuResolved,
 				isNavigationMenuMissing,
-
-				canUserCreateNavigationMenu: canCreate,
-				isResolvingCanUserCreateNavigationMenu: isResolving,
-				hasResolvedCanUserCreateNavigationMenu: hasResolved,
-
-				canUserUpdateNavigationMenu: canUpdate,
-				hasResolvedCanUserUpdateNavigationMenu: ref
-					? hasResolved
-					: undefined,
-
-				canUserDeleteNavigationMenu: canDelete,
-				hasResolvedCanUserDeleteNavigationMenu: ref
-					? hasResolved
-					: undefined,
 			};
 		},
-		[ ref, permissions ]
+		[ ref ]
 	);
 
+	const { canCreate, canUpdate, canDelete, isResolving, hasResolved } =
+		permissions;
+
 	const {
 		records: navigationMenus,
 		isResolving: isResolvingNavigationMenus,
 		hasResolved: hasResolvedNavigationMenus,
-		canSwitchNavigationMenu = ref
-			? navigationMenus?.length > 1
-			: navigationMenus?.length > 0,
 	} = useEntityRecords(
 		'postType',
 		`wp_navigation`,
 		PRELOADED_NAVIGATION_MENUS_QUERY
 	);
 
+	const canSwitchNavigationMenu = ref
+		? navigationMenus?.length > 1
+		: navigationMenus?.length > 0;
+
 	return {
 		...useSelectResult,
 		navigationMenus,
 		isResolvingNavigationMenus,
 		hasResolvedNavigationMenus,
 		canSwitchNavigationMenu,
+		canUserCreateNavigationMenu: canCreate,
+		isResolvingCanUserCreateNavigationMenu: isResolving,
+		hasResolvedCanUserCreateNavigationMenu: hasResolved,
+		canUserUpdateNavigationMenu: canUpdate,
+		hasResolvedCanUserUpdateNavigationMenu: ref ? hasResolved : undefined,
+		canUserDeleteNavigationMenu: canDelete,
+		hasResolvedCanUserDeleteNavigationMenu: ref ? hasResolved : undefined,
 	};
 }