Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block: overlay covers the text when the block is aligned to the left/right/center #11382

Closed
dashkevych opened this issue Nov 1, 2018 · 2 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended

Comments

@dashkevych
Copy link

dashkevych commented Nov 1, 2018

Describe the bug
When the Cover block is aligned to the left or to the right or to the center, the overlay covers the text and causes readability issues.

If the block does not have any alignment then it works fine. The text appears above the overlay.

Also, the content is not vertically aligned on the front end.

To Reproduce
Steps to reproduce the behavior:

  1. Create the Cover block;
  2. Select block alignment (left/right/center);
  3. Select overlay color;
  4. Set background opacity (I've set it to 80);
  5. Update post and see front end;

Expected behavior
The text of the Cover block should appear above the overlay.

Screenshots

Dashboard:

Dashboard

Front end:

Front end

Desktop (please complete the following information):

  • OS: macOS 10.13.6
  • Chrome
  • Version 69.0.3497.100
  • WordPress: 5.0-beta2-43852
  • Theme: Twenty Seventeen (1.7)
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Nov 5, 2018
@designsimply
Copy link
Member

Tested with WordPress 4.9.8 and Gutenberg 4.2.0 and confirmed and found that this problem happens even without changing the overlay color or opacity.

  1. Add a cover block.
  2. Add some text into the cover block.
  3. Select "Align right" in the block toolbar.
  4. Publish and view the post.
  5. Check to see if the cover block view reasonably matches with what was showing in the editor.

Result: when the cover block is aligned right, the text added appears at the top instead of centered vertically like it is in the editor and the text is behind the overlay which also looks different in the editor view. I expected the vertical alignment of the text and the overlay order to match.

screen shot 2018-11-07 at 11 55 37 am

screen shot 2018-11-07 at 11 55 24 am

Seen at http://alittletestblog.com/wp-admin/post.php?post=15605&action=edit running and http://alittletestblog.com/2018/11/07/cover-block-alignment-test/ WordPress 4.9.8 and Gutenberg 4.2.0 and theme Twenty Seventeen 1.7 using Firefox 63.0.1 on macOS 10.13.6.

@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Block] Cover Affects the Cover Block - used to display content laid over a background image and removed Needs Testing Needs further testing to be confirmed. labels Nov 7, 2018
@m-e-h
Copy link
Member

m-e-h commented Nov 16, 2018

This should be fixed in #11990

@mtias mtias closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants