Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of Block inserter at bottom of page #11909

Closed
maddisondesigns opened this issue Nov 15, 2018 · 16 comments
Closed

Inconsistent use of Block inserter at bottom of page #11909

maddisondesigns opened this issue Nov 15, 2018 · 16 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable.

Comments

@maddisondesigns
Copy link

Describe the bug
You've repeatedly said that the block inserter wont appear at the bottom of the page if the last block is a Paragraph Block. I have two sites that are both running the same version of WP 5.0 and I've activated TwentyNineteen.

I've opened up a page on each site. Both pages have a Paragraph Block as the last block. One site shows the block inserter at the bottom of the page, one site doesn't.

On the site where it is showing, if I switch to TwentySeventeen and open the same page, the block inserter still shows at the bottom of the page.

On the site where it isn't showing, if I switch to TwentySeventeen (or even my own theme), the block inserter doesn't show.

Just to confirm that they are running identical WP versions

Site 1:
screenshot_943

Site 2:
screenshot_944

Site 1: Block inserter doesn't show
screenshot_942

Site 2: Block inserter does show
screenshot_940

And just to show that both have the same options enabled/disabled

Site 1:
screenshot_946

Site 2:
screenshot_945

To Reproduce
Steps to reproduce the behavior:

  1. Switch to TwentyNineteen
  2. Edit page and add paragraph block to end of content
  3. See if the block inserter shows

Expected behavior
I expect two identical versions of WordPress, running the exact same theme, to work identically

Desktop (please complete the following information):

  • macOS Sierra 10.12.6
  • Firefox Quantum 63.0.1 (64-bit)
  • WP 5.0-beta4-43896
  • TwentyNineteen
@designsimply designsimply added [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Testing Needs further testing to be confirmed. labels Nov 15, 2018
@maddisondesigns
Copy link
Author

WP 5.0-RC1-43944 and this issue is still there

@maddisondesigns
Copy link
Author

Issue still exists in 5.0-RC2-43958

@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Needs Testing Needs further testing to be confirmed. and removed Needs Testing Needs further testing to be confirmed. [Type] Bug An existing feature does not function as intended labels Oct 2, 2019
@youknowriad
Copy link
Contributor

In the last versions, we tweaked that behavior a little bit. Are you still able to reproduce the issue?

@youknowriad youknowriad added the [Status] Needs More Info Follow-up required in order to be actionable. label Oct 2, 2019
@maddisondesigns
Copy link
Author

Yes, I'm still able to reproduce this issue.

These first two screens are on the same site. Editing one page, it shows "Start writing or type / to choose a block" at the bottom, whilst editing another page, it doesn't.

screenshot_220

screenshot_221

This page is on another site. Editing this page it shows "Start writing or type / to choose a block" at the bottom, as well as the Plus (+) inserter icon.

screenshot_222

All three pages end with Paragraph Blocks.
Both sites are running the same version of WordPress (5.3-beta2-46382).
One site is using TwentyNineteen and the other is using TwentyTwenty.
Not only is it inconsistent as to whether it shows that message at the bottom of the page, but it's also inconsistent with how it displays it (one with the block inserter icon, and one without).

@youknowriad
Copy link
Contributor

Thanks for testing @maddisondesigns

The difference between the first and the last screenshot is a bug. Right now, we're always showing the text and the icon if the last block is an empty paragraph

The second screenshot is expected though because your last block is a paragraph and the paragraph is not empty (so no icon and no text).

@maddisondesigns
Copy link
Author

maddisondesigns commented Oct 4, 2019

There's no empty Paragraph blocks though. I didn't hit Enter on that later Paragraph, which would then insert a new empty Parapgraph block. All I did was opened the page to edit it and then took a screenshot. The last Block in all three pages, is a Paragraph block with text in it.

@youknowriad
Copy link
Contributor

Would you mind sharing the HTML content (switch to code editor) of your page? That's indeed very weird. Is it possible that you have a plugin automatically adding empty paragraphs at the end for some reason?

@maddisondesigns
Copy link
Author

Here's the content for each of those screens. There's certainly nothing that interesting in the content that should cause this inconsistency, and I definitely don't have any plugins that would automatically add empty paragraph blocks.

On the first site (first two screnshots), the plugins are:
Advanced Custom Fields
Classic Editor
Elementor
Elementor Pro
Gravity Forms
WooCommerce

On the second site (third screenshot):
WordPress Importer

#1

<!-- wp:paragraph -->
<p>Cras mattis iudicium purus sit amet fermentum. Non equidem invideo, miror magis posuere velit aliquet. Prima luce, cum quibus mons aliud consensu ab eo. Paullum deliquit, ponderibus modulisque suis ratio utitur. Fabio vel iudice vincam, sunt in culpa qui officia. Plura mihi bona sunt, inclinet, amari petere vellent. Ab illo tempore, ab est sed immemorabili. Mercedem aut nummos unde unde extricat, amaras. Nihilne te nocturnum praesidium Palati, nihil urbis vigiliae. [font_awesome icon="fa-twitter"]http://twitter.com[/font_awesome] Qui ipsorum lingua Celtae, nostra Galli appellantur. Magna pars studiorum, prodita quaerimus. Quisque placerat facilisis egestas cillum dolore. nmgjgj<br></p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"dropCap":true,"textColor":"white-smoke","backgroundColor":"denim"} -->
<p class="has-text-color has-background has-drop-cap has-white-smoke-color has-denim-background-color">Cras mattis iudicium purus sit amet fermentum. Non equidem invideo, miror magis posuere velit aliquet. Prima luce, cum quibus mons aliud consensu ab eo. Paullum deliquit, ponderibus modulisque suis ratio utitur. Fabio vel iudice vincam, sunt in culpa qui officia. Plura mihi bona sunt, inclinet, amari petere vellent. Ab illo tempore, ab est sed immemorabili. Mercedem aut nummos unde unde extricat, amaras. Nihilne te nocturnum praesidium Palati, nihil urbis vigiliae. Qui ipsorum lingua Celtae, nostra Galli appellantur. Magna pars studiorum, prodita quaerimus. Quisque placerat facilisis egestas cillum dolore.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

#2

<!-- wp:paragraph -->
<p>Curabitur blandit tempus ardua ridiculus sed magna. Quo usque tandem abutere, Catilina, patientia nostra? Morbi fringilla convallis sapien, id pulvinar odio volutpat. Gallia est omnis divisa in partes tres, quarum. Salutantibus vitae elit libero, a pharetra augue. Quid securi etiam tamquam eu fugiat nulla pariatur.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p>Nihilne te nocturnum praesidium Palati, nihil urbis vigiliae. Ab illo tempore, ab est sed immemorabili. Morbi odio eros, volutpat ut pharetra vitae, lobortis sed nibh.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p>Cum sociis natoque penatibus et magnis dis parturient. Quis aute iure reprehenderit in voluptate velit esse. Sed haec quis possit intrepidus aestimare tellus. Lorem ipsum dolor sit amet, consectetur adipisici elit, sed eiusmod tempor incidunt ut labore et dolore magna aliqua. Ullamco laboris nisi ut aliquid ex ea commodi consequat. Nihil hic munitissimus habendi senatus locus, nihil horum?</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p>Curabitur blandit tempus ardua ridiculus sed magna. Quo usque tandem abutere, Catilina, patientia nostra? Morbi fringilla convallis sapien, id pulvinar odio volutpat. Gallia est omnis divisa in partes tres, quarum. Salutantibus vitae elit libero, a pharetra augue. Quid securi etiam tamquam eu fugiat nulla pariatur.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p>Nihilne te nocturnum praesidium Palati, nihil urbis vigiliae. Ab illo tempore, ab est sed immemorabili. Morbi odio eros, volutpat ut pharetra vitae, lobortis sed nibh.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p>Cum sociis natoque penatibus et magnis dis parturient. Quis aute iure reprehenderit in voluptate velit esse. Sed haec quis possit intrepidus aestimare tellus. Lorem ipsum dolor sit amet, consectetur adipisici elit, sed eiusmod tempor incidunt ut labore et dolore magna aliqua. Ullamco laboris nisi ut aliquid ex ea commodi consequat. Nihil hic munitissimus habendi senatus locus, nihil horum?</p>
<!-- /wp:paragraph -->

#3

<!-- wp:heading -->
<h2>Audio Block</h2>
<!-- /wp:heading -->

<!-- wp:audio {"id":2837} -->
<figure class="wp-block-audio"><audio controls src="http://dev.ephemeris.com/wp-content/uploads/2018/05/02-Brave-Enough-ft.-Christina-Perri.mp3"></audio></figure>
<!-- /wp:audio -->

<!-- wp:heading -->
<h2>Cover Block</h2>
<!-- /wp:heading -->

<!-- wp:cover {"url":"http://dev.ephemeris.com/wp-content/uploads/2017/11/bigstock-Beauty-Girl-Outdoors-enjoying-60280580.jpg","id":2750,"focalPoint":{"x":0.5023041474654378,"y":0.5}} -->
<div class="wp-block-cover has-background-dim" style="background-image:url(http://dev.ephemeris.com/wp-content/uploads/2017/11/bigstock-Beauty-Girl-Outdoors-enjoying-60280580.jpg);background-position:50.23041474654379% 50%"><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","placeholder":"Write title…","fontSize":"large"} -->
<p class="has-text-align-center has-large-font-size">Cover Image<br></p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:cover -->

<!-- wp:heading -->
<h2>File Block</h2>
<!-- /wp:heading -->

<!-- wp:file {"id":1747,"href":"http://your-wordpress-site.com/wp-content/uploads/2013/11/main-shuttle-crew-operations-manual.pdf"} -->
<div class="wp-block-file"><a href="http://your-wordpress-site.com/wp-content/uploads/2013/11/main-shuttle-crew-operations-manual.pdf">Main Shuttle Crew Operations Manual</a><a href="http://your-wordpress-site.com/wp-content/uploads/2013/11/main-shuttle-crew-operations-manual.pdf" class="wp-block-file__button" download>Download</a></div>
<!-- /wp:file -->

<!-- wp:heading -->
<h2>Gallery Block<br></h2>
<!-- /wp:heading -->

<!-- wp:gallery {"ids":[2945,2916,2901,2838,2753],"className":"alignfull"} -->
<figure class="wp-block-gallery columns-3 is-cropped alignfull"><ul class="blocks-gallery-grid"><li class="blocks-gallery-item"><figure><img src="http://dev.ephemeris.com/wp-content/uploads/2018/08/pixabay-beautiful-1869583.jpg" alt="" data-id="2945" data-link="http://dev.ephemeris.com/welcome-to-the-gutenberg-editor/pixabay-beautiful-1869583/" class="wp-image-2945"/><figcaption class="blocks-gallery-item__caption">This is an image caption</figcaption></figure></li><li class="blocks-gallery-item"><figure><img src="http://dev.ephemeris.com/wp-content/uploads/2017/11/bigstock-Beauty-Girl-Outdoors-enjoying-60280580.jpg" alt="" data-id="2916" data-link="http://dev.ephemeris.com/the-great-outdoors/bigstock-beauty-girl-outdoors-enjoying-60280580/" class="wp-image-2916"/></figure></li><li class="blocks-gallery-item"><figure><img src="http://dev.ephemeris.com/wp-content/uploads/2018/07/bigstock-Monument-Valley-46024285.jpg" alt="" data-id="2901" data-link="http://dev.ephemeris.com/sample-page-with-default-template/bigstock-monument-valley-46024285/" class="wp-image-2901"/><figcaption class="blocks-gallery-item__caption">This is an image caption</figcaption></figure></li><li class="blocks-gallery-item"><figure><img src="http://dev.ephemeris.com/wp-content/uploads/2018/05/02-Brave-Enough-ft-Christina-Perri-mp3-image.jpg" alt="" data-id="2838" data-link="http://dev.ephemeris.com/2838/" class="wp-image-2838"/></figure></li><li class="blocks-gallery-item"><figure><img src="http://dev.ephemeris.com/wp-content/uploads/2017/11/bigstock-Stockholm-46423090.jpg" alt="" data-id="2753" data-link="http://dev.ephemeris.com/beautiful-stockholm/bigstock-stockholm-46423090/" class="wp-image-2753"/><figcaption class="blocks-gallery-item__caption">This is an image caption</figcaption></figure></li></ul></figure>
<!-- /wp:gallery -->

<!-- wp:heading {"level":1} -->
<h1>Heading 1</h1>
<!-- /wp:heading -->

<!-- wp:heading -->
<h2>Heading 2</h2>
<!-- /wp:heading -->

<!-- wp:heading {"level":3} -->
<h3>Heading 3</h3>
<!-- /wp:heading -->

<!-- wp:heading {"level":4} -->
<h4>Heading 4</h4>
<!-- /wp:heading -->

<!-- wp:heading {"level":5} -->
<h5>Heading 5</h5>
<!-- /wp:heading -->

<!-- wp:heading {"level":6} -->
<h6>Heading 6</h6>
<!-- /wp:heading -->

<!-- wp:heading -->
<h2>Image Block</h2>
<!-- /wp:heading -->

<!-- wp:image {"id":2103} -->
<figure class="wp-block-image"><img src="http://your-wordpress-site.com/wp-content/uploads/2018/10/rodrigo-soares-487443-unsplash-1024x768.jpg" alt="" class="wp-image-2103"/></figure>
<!-- /wp:image -->

<!-- wp:image {"align":"full","id":2101} -->
<figure class="wp-block-image alignfull"><img src="http://your-wordpress-site.com/wp-content/uploads/2018/10/pascal-debrunner-634122-unsplash-1024x683.jpg" alt="" class="wp-image-2101"/></figure>
<!-- /wp:image -->

<!-- wp:heading -->
<h2>List Block<br></h2>
<!-- /wp:heading -->

<!-- wp:list -->
<ul><li> List Item 1</li><li>List Item 2</li><li>List Item 3</li><li>List Item 4</li><li>List Item 5</li></ul>
<!-- /wp:list -->

<!-- wp:list {"ordered":true} -->
<ol><li>Numbered List Item 1</li><li>Numbered List Item 2</li><li>Numbered List Item 3</li><li>Numbered List Item 4</li><li>Numbered List Item 5</li></ol>
<!-- /wp:list -->

<!-- wp:heading -->
<h2>Paragraph Block</h2>
<!-- /wp:heading -->

<!-- wp:paragraph {"textColor":"white","backgroundColor":"primary"} -->
<p class="has-text-color has-background has-white-color has-primary-background-color">Look again at that dot. That’s here. That’s home. That’s us. On it everyone you love, everyone you know, everyone you ever heard of, every human being who ever was, lived out their lives.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p>The aggregate of our joy and suffering, thousands of confident religions, ideologies, and economic doctrines, every hunter and forager, every hero and coward, every creator and destroyer of civilization, every king and peasant, every young couple in love, every mother and father, hopeful child, inventor and explorer, every teacher of morals, every corrupt politician, every “superstar,” every “supreme leader,” every saint and sinner in the history of our species lived there–on a mote of dust suspended in a sunbeam.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph {"textColor":"San Juan","backgroundColor":"white-smoke"} -->
<p class="has-text-color has-background has-san-juan-color has-white-smoke-background-color">A Paragraph block with background and text colours. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Proin sed erat at dolor vulputate pretium. Praesent mauris est, mollis sed dapibus at, pretium ut orci. Morbi elit felis, porttitor vel mauris nec, venenatis facilisis magna. Nunc pulvinar euismod maximus. Maecenas in ullamcorper sem. Ut tempor neque eu erat venenatis mollis. Proin consequat turpis ac metus gravida vulputate. Sed dui sem, ultricies ac sem at, ultricies vestibulum nibh. Donec eu massa sit amet ex maximus fringilla. Donec fermentum volutpat erat eget rutrum. Fusce varius, tellus vitae pretium placerat, felis ligula viverra magna, sed porta turpis diam id nibh. Praesent sit amet augue ac ligula elementum ullamcorper eget non sem. Curabitur eu metus lacus. Duis semper elementum magna, vel pharetra arcu fringilla vel.</p>
<!-- /wp:paragraph -->

<!-- wp:heading -->
<h2>Quote Block</h2>
<!-- /wp:heading -->

<!-- wp:quote {"className":"is-style-default"} -->
<blockquote class="wp-block-quote is-style-default"><p>Iron Man. That’s kind of catchy. It’s got a nice ring to it. I mean it’s not technically accurate. The suit’s a gold titanium alloy, but it’s kind of provocative, the imagery anyway.</p><cite>Tony Stark - Iron Man</cite></blockquote>
<!-- /wp:quote -->

<!-- wp:quote {"align":"center","className":"is-style-large"} -->
<blockquote class="wp-block-quote has-text-align-center is-style-large"><p>When the mob and the press and the whole world tell you to move, your job is to plant yourself like a tree by the river of truth, and tell the whole world “No, You Move.”</p><cite>Captain America</cite></blockquote>
<!-- /wp:quote -->

<!-- wp:heading -->
<h2>Video Block</h2>
<!-- /wp:heading -->

<!-- wp:video {"id":1690} -->
<figure class="wp-block-video"><video controls src="http://dev.ephemeris.com/wp-content/uploads/2013/12/2014-slider-mobile-behavior.mov"></video></figure>
<!-- /wp:video -->

<!-- wp:heading -->
<h2>Code Block</h2>
<!-- /wp:heading -->

<!-- wp:code -->
<pre class="wp-block-code"><code>&lt;?php
/**
 * Enqueue scripts and styles.
 * Our sample Social Icons are using Font Awesome to display the icons so we need to include the FA CSS
 *
 * @return void
 */
if ( ! function_exists( 'skyrocket_scripts_styles' ) ) {
	function skyrocket_scripts_styles() {
		// Register and enqueue our icon font
		// We're using the awesome Font Awesome icon font. http://fortawesome.github.io/Font-Awesome
		wp_register_style( 'fontawesome', trailingslashit( get_template_directory_uri() ) . 'css/font-awesome.min.css' , array(), '4.7', 'all' );
		wp_enqueue_style( 'fontawesome' );
	}
}
add_action( 'wp_enqueue_scripts', 'skyrocket_scripts_styles' );</code></pre>
<!-- /wp:code -->

<!-- wp:heading -->
<h2>Classic Block</h2>
<!-- /wp:heading -->

<p>Look again at that dot. That's here. That's home. That's us. On it everyone you love, everyone you know, everyone you ever heard of, every human being who ever was, lived out their lives. The aggregate of our joy and suffering, thousands of confident religions, ideologies, and economic doctrines, every hunter and forager, every hero and coward, every creator and destroyer of civilization, every king and peasant, every young couple in love, every mother and father, hopeful child, inventor and explorer, every teacher of morals, every corrupt politician, every "superstar," every "supreme leader," every saint and sinner in the history of our species lived there--on a mote of dust suspended in a sunbeam.</p>
<p>The Earth is a very small stage in a vast cosmic arena. Think of the rivers of blood spilled by all those generals and emperors so that, in glory and triumph, they could become the momentary masters of a fraction of a dot. Think of the endless cruelties visited by the inhabitants of one corner of this pixel on the scarcely distinguishable inhabitants of some other corner, how frequent their misunderstandings, how eager they are to kill one another, how fervent their hatreds.</p>
<p>Our posturings, our imagined self-importance, the delusion that we have some privileged position in the Universe, are challenged by this point of pale light. Our planet is a lonely speck in the great enveloping cosmic dark. In our obscurity, in all this vastness, there is no hint that help will come from elsewhere to save us from ourselves.</p>
<p>The Earth is the only world known so far to harbor life. There is nowhere else, at least in the near future, to which our species could migrate. Visit, yes. Settle, not yet. Like it or not, for the moment the Earth is where we make our stand.</p>
<p>It has been said that astronomy is a humbling and character-building experience. There is perhaps no better demonstration of the folly of human conceits than this distant image of our tiny world. To me, it underscores our responsibility to deal more kindly with one another, and to preserve and cherish the pale blue dot, the only home we've ever known.</p>

<!-- wp:heading -->
<h2>Custom HTML Block</h2>
<!-- /wp:heading -->

<!-- wp:html -->
<div class="my-customer-html-block" style="color:#fff;background-color:rebeccapurple;padding:50px 0;text-align:center;font-weight:700;font-size:30px;">Custom HTML Block</div>
<!-- /wp:html -->

<!-- wp:html -->
<div class="my-customer-html-block" style="color:#fff;background-color:rebeccapurple;padding:50px 0;text-align:center;font-weight:700;font-size:30px;">
	Custom HTML Block
</div>
<!-- /wp:html -->

<!-- wp:heading -->
<h2>Preformatted Block</h2>
<!-- /wp:heading -->

<!-- wp:preformatted -->
<pre class="wp-block-preformatted">Vivamus sagittis lacus vel augue laoreet rutrum faucibus. Praeterea iter est quasdam res quas ex communi. Ullamco laboris nisi ut aliquid ex ea commodi consequat. Nihilne te nocturnum praesidium Palati, nihil urbis vigiliae.</pre>
<!-- /wp:preformatted -->

<!-- wp:heading -->
<h2>Pullquote Block</h2>
<!-- /wp:heading -->

<!-- wp:pullquote {"className":"alignnone is-style-default"} -->
<figure class="wp-block-pullquote alignnone is-style-default"><blockquote><p>Look again at that dot. That's here. That's home. That's us.</p><cite>Carl Sagan - Pale Blue Dot: A Vision of the Human Future in Space</cite></blockquote></figure>
<!-- /wp:pullquote -->

<!-- wp:heading -->
<h2>Table Block</h2>
<!-- /wp:heading -->

<!-- wp:table {"className":"is-style-regular"} -->
<figure class="wp-block-table is-style-regular"><table class=""><tbody><tr><td></td><td>Qtr 1 </td><td>Qtr 2</td></tr><tr><td>2016</td><td>$16,000</td><td>$14,000</td></tr><tr><td>2017</td><td>$24,015</td><td>$16,035</td></tr><tr><td>2018</td><td>$23,500</td><td>$19,075</td></tr></tbody></table></figure>
<!-- /wp:table -->

<!-- wp:heading -->
<h2>Verse Block</h2>
<!-- /wp:heading -->

<!-- wp:verse -->
<pre class="wp-block-verse">A star frightens the steeple cross<br>a horse gasps smoke<br>iron clanks drowsily<br>mists spread<br>fears<br>staring shivering<br>shivering<br>cajoling<br>whispering<br>You!</pre>
<!-- /wp:verse -->

<!-- wp:heading -->
<h2>Button Block</h2>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Look again at that dot. That's here. That's home. That's us. On it everyone you love, everyone you know, everyone you ever heard of, every human being who ever was, lived out their lives.</p>
<!-- /wp:paragraph -->

<!-- wp:button {"backgroundColor":"eclipse","className":"alignnone is-style-default"} -->
<div class="wp-block-button alignnone is-style-default"><a class="wp-block-button__link has-background has-eclipse-background-color" href="http://dev.ephemeris.com/markup-html-tags-and-formatting/">Download</a></div>
<!-- /wp:button -->

<!-- wp:heading -->
<h2>Columns Block</h2>
<!-- /wp:heading -->

<!-- wp:columns {"className":"has-3-columns"} -->
<div class="wp-block-columns has-3-columns"><!-- wp:column -->
<div class="wp-block-column"><!-- wp:paragraph -->
<p>Lorem ipsum dolor sit amet, consectetur adipisici elit, sed eiusmod tempor.</p>
<!-- /wp:paragraph --></div>
<!-- /wp:column -->

<!-- wp:column -->
<div class="wp-block-column"><!-- wp:paragraph -->
<p>Plura mihi bona sunt, inclinet, amari petere vellent. Ab illo tempore, ab est sed.</p>
<!-- /wp:paragraph --></div>
<!-- /wp:column -->

<!-- wp:column -->
<div class="wp-block-column"><!-- wp:paragraph -->
<p>Praeterea iter est quasdam res quas ex communi.</p>
<!-- /wp:paragraph -->

<!-- wp:button {"className":"is-style-outline"} -->
<div class="wp-block-button is-style-outline"><a class="wp-block-button__link" href="#">Download...</a></div>
<!-- /wp:button --></div>
<!-- /wp:column --></div>
<!-- /wp:columns -->

<!-- wp:heading -->
<h2>Media &amp; Text Block</h2>
<!-- /wp:heading -->

<!-- wp:media-text {"mediaId":2099,"mediaType":"image"} -->
<div class="wp-block-media-text alignwide"><figure class="wp-block-media-text__media"><img src="http://your-wordpress-site.com/wp-content/uploads/2018/10/johannes-plenio-629984-unsplash-1024x683.jpg" alt="" class="wp-image-2099"/></figure><div class="wp-block-media-text__content"><!-- wp:paragraph -->
<p>Lorem ipsum dolor sit amet, consectetur adipisici elit.</p>
<!-- /wp:paragraph --></div></div>
<!-- /wp:media-text -->

<!-- wp:paragraph -->
<p>Curabitur blandit tempus ardua ridiculus sed magna. Cras mattis iudicium purus sit amet fermentum. Non equidem invideo, miror magis posuere velit aliquet. Pellentesque habitant morbi tristique senectus et netus. Vivamus sagittis lacus vel augue laoreet rutrum faucibus.</p>
<!-- /wp:paragraph -->

<!-- wp:heading -->
<h2>More Block</h2>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Curabitur blandit tempus ardua ridiculus sed magna. Cras mattis iudicium purus sit amet fermentum. Non equidem invideo, miror magis posuere velit aliquet. Pellentesque habitant morbi tristique senectus et netus. Vivamus sagittis lacus vel augue laoreet rutrum faucibus.</p>
<!-- /wp:paragraph -->

<!-- wp:more -->
<!--more-->
<!-- /wp:more -->

<!-- wp:heading -->
<h2>Page Break Block</h2>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Lorem ipsum dolor sit amet, consectetur adipisici elit, sed eiusmod tempor incidunt ut labore et dolore magna aliqua. Contra legem facit qui id facit quod lex prohibet.</p>
<!-- /wp:paragraph -->

<!-- wp:nextpage -->
<!--nextpage-->
<!-- /wp:nextpage -->

<!-- wp:heading -->
<h2>Separator Block</h2>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>Look again at that dot. That’s here. That’s home. That’s us. On it everyone you love, everyone you know, everyone you ever heard of, every human being who ever was, lived out their lives.</p>
<!-- /wp:paragraph -->

<!-- wp:separator {"className":"is-style-dots"} -->
<hr class="wp-block-separator is-style-dots"/>
<!-- /wp:separator -->

<!-- wp:paragraph -->
<p>The aggregate of our joy and suffering, thousands of confident religions, ideologies, and economic doctrines, every hunter and forager, every hero and coward, every creator and destroyer of civilization, every king and peasant, every young couple in love, every mother and father, hopeful child, inventor and explorer, every teacher of morals, every corrupt politician, every "superstar," every "supreme leader," every saint and sinner in the history of our species lived there--on a mote of dust suspended in a sunbeam.</p>
<!-- /wp:paragraph -->

<!-- wp:heading -->
<h2>Spacer Block</h2>
<!-- /wp:heading -->

<!-- wp:paragraph -->
<p>The Earth is a very small stage in a vast cosmic arena. Think of the rivers of blood spilled by all those generals and emperors so that, in glory and triumph, they could become the momentary masters of a fraction of a dot. </p>
<!-- /wp:paragraph -->

<!-- wp:spacer {"height":50} -->
<div style="height:50px" aria-hidden="true" class="wp-block-spacer"></div>
<!-- /wp:spacer -->

<!-- wp:paragraph -->
<p>Think of the endless cruelties visited by the inhabitants of one corner of this pixel on the scarcely distinguishable inhabitants of some other corner, how frequent their misunderstandings, how eager they are to kill one another, how fervent their hatreds.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p>Our posturings, our imagined self-importance, the delusion that we have some privileged position in the Universe, are challenged by this point of pale light. Our planet is a lonely speck in the great enveloping cosmic dark. In our obscurity, in all this vastness, there is no hint that help will come from elsewhere to save us from ourselves.</p>
<!-- /wp:paragraph -->

<!-- wp:heading -->
<h2>Archives Block</h2>
<!-- /wp:heading -->

<!-- wp:archives /-->

<!-- wp:heading -->
<h2>Calendar Block</h2>
<!-- /wp:heading -->

<!-- wp:calendar /-->

<!-- wp:heading -->
<h2>Categories Block</h2>
<!-- /wp:heading -->

<!-- wp:categories {"showHierarchy":true} /-->

<!-- wp:heading {"level":3} -->
<h3>Latest Comments Block</h3>
<!-- /wp:heading -->

<!-- wp:latest-comments /-->

<!-- wp:heading -->
<h2>Latest Posts Block</h2>
<!-- /wp:heading -->

<!-- wp:latest-posts {"displayPostDate":true} /-->

<!-- wp:heading -->
<h2>RSS Block</h2>
<!-- /wp:heading -->

<!-- wp:rss {"feedURL":"http://your-wordpress-site.com/feed","displayDate":true} /-->

<!-- wp:heading -->
<h2>Search Block</h2>
<!-- /wp:heading -->

<!-- wp:search /-->

<!-- wp:paragraph -->
<p>Look again at that dot. That’s here. That’s home. That’s us. On it everyone you love, everyone you know, everyone you ever heard of, every human being who ever was, lived out their lives. The aggregate of our joy and suffering, thousands of confident religions, ideologies, and economic doctrines, every hunter and forager, every hero and coward, every creator and destroyer of civilization, every king and peasant, every young couple in love, every mother and father, hopeful child, inventor and explorer, every teacher of morals, every corrupt politician, every "superstar," every "supreme leader," every saint and sinner in the history of our species lived there--on a mote of dust suspended in a sunbeam.</p>
<!-- /wp:paragraph -->

<!-- wp:heading -->
<h2>Shortcode Block</h2>
<!-- /wp:heading -->

<!-- wp:shortcode -->
[products limit="8" columns="4" orderby="date" category="clothing"]
<!-- /wp:shortcode -->

<!-- wp:heading -->
<h2>Tag Cloud Block</h2>
<!-- /wp:heading -->

<!-- wp:tag-cloud /-->

<!-- wp:paragraph -->
<p>Look again at that dot. That’s here. That’s home. That’s us. On it everyone you love, everyone you know, everyone you ever heard of, every human being who ever was, lived out their lives. The aggregate of our joy and suffering, thousands of confident religions, ideologies, and economic doctrines, every hunter and forager, every hero and coward, every creator and destroyer of civilization, every king and peasant, every young couple in love, every mother and father, hopeful child, inventor and explorer, every teacher of morals, every corrupt politician, every "superstar," every "supreme leader," every saint and sinner in the history of our species lived there--on a mote of dust suspended in a sunbeam.</p>
<!-- /wp:paragraph -->

<!-- wp:heading {"level":3} -->
<h3>YouTube Embed Block</h3>
<!-- /wp:heading -->

<!-- wp:core-embed/youtube {"url":"https://www.youtube.com/watch?v=Ki_Af_o9Q9s","type":"video","providerNameSlug":"youtube","className":"wp-embed-aspect-16-9 wp-has-aspect-ratio"} -->
<figure class="wp-block-embed-youtube wp-block-embed is-type-video is-provider-youtube wp-embed-aspect-16-9 wp-has-aspect-ratio"><div class="wp-block-embed__wrapper">
https://www.youtube.com/watch?v=Ki_Af_o9Q9s
</div><figcaption>Team members at NASA's Jet Propulsion Laboratory share the challenges of the Curiosity Mars rover's final minutes to landing on the surface of Mars.</figcaption></figure>
<!-- /wp:core-embed/youtube -->

<!-- wp:paragraph -->
<p>The Mars Science Laboratory mission's Curiosity rover, the most technologically advanced rover ever built, landed in Mars' Gale Crater the evening of August 5, 2012 PDT (morning of August 6 EDT) using a series of complicated landing maneuvers never before attempted. The specialized landing sequence, which employed a giant parachute, a jet-controlled descent vehicle and a bungee-like apparatus called a "sky crane," was devised because tested landing techniques used during previous rover missions could not safely accommodate the much larger and heavier rover.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p>Curiosity's mission is to determine whether the Red Planet ever was, or is, habitable to microbial life. The rover, which is about the size of a MINI Cooper, is equipped with 17 cameras and a robotic arm containing a suite of specialized laboratory-like tools and instruments.</p>
<!-- /wp:paragraph -->

<!-- wp:heading {"level":3} -->
<h3>Reusable Block</h3>
<!-- /wp:heading -->

<!-- wp:block {"ref":2577} /-->

<!-- wp:paragraph -->
<p>Look again at that dot. That’s here. That’s home. That’s us. On it everyone you love, everyone you know, everyone you ever heard of, every human being who ever was, lived out their lives. The aggregate of our joy and suffering, thousands of confident religions, ideologies, and economic doctrines, every hunter and forager, every hero and coward, every creator and destroyer of civilization, every king and peasant, every young couple in love, every mother and father, hopeful child, inventor and explorer, every teacher of morals, every corrupt politician, every "superstar," every "supreme leader," every saint and sinner in the history of our species lived there--on a mote of dust suspended in a sunbeam.</p>
<!-- /wp:paragraph -->

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

@youknowriad
Copy link
Contributor

This

<!-- wp:paragraph -->
<p></p>
<!-- /wp:paragraph -->

is an empty paragraph block, right?

@maddisondesigns
Copy link
Author

Hmmm You're right. But why is it saving empty paragraph blocks on the end?

If I type (or copy) in a few paragraphs of content, and then happen to hit enter on that last paragraph, it shouldn't just insert a new empty paragraph block. The block should only be inserted when I actually click on it and start typing.

@youknowriad
Copy link
Contributor

Technically, it's very hard to make something work like a block but not be a block. Basically you're suggesting like when you first type a character, transform that input into a paragraph. This is challenging for different reasons:

  • Some people don't just type, you can for example hit "ctrl + b" and then start typing with bold. So a simple input won't work.
  • Also, this means when you type the first character, the input is transformed to a block and render a RichText and keep the caret at the right position, you can imagine how complex this can be.

In the end, we don't think it's worth the complexity.

@maddisondesigns
Copy link
Author

Sure, I can understand the difficulties with that. If you didn't break everything down into single paragraph blocks, you wouldn't have these issues . The editor shouldn't be auto-inserting blocks into your content. It should be entirely up to the user as to whether they want to insert a block. If the Paragraph block allowed multiple paragraphs of content, then there'd be no reason to auto-insert a new one when hitting Enter, which would also mean this issues wouldn't occur. It would also make editing your content significantly easier because this whole individual paragraph block thing, makes editing text heavy pages a nightmare.

@youknowriad
Copy link
Contributor

That's your opinion and a valid one. When we tried multiple paragraphs in a single block initially, feedback suggested that it was confusing for users, when and why to break into separate blocks and how to apply block-level controls to a single paragraph and not the whole block. There are definitely drawbacks for each approach but I think the current one has fewer drawbacks than the previous one. Also, not exactly the right place to discuss this.

@maddisondesigns
Copy link
Author

If you tried it initially, then you only tried it amongst yourselves, which means that it was a very tiny audience that came to that decision that it was too confusing. Ever since the Gutenberg plugin was first released, which is basically when the wider WP community first heard about Gutenberg, and was able to try it, the Paragraph block has only ever supported a single paragraph. I've been testing this thing from day one, and it's never allowed more than one paragraph.

But you're right, this is not the place. It's obviously not going to change now. Feel free to close this if you'd like as those blank paragraph blocks seem to be the cause of the initial issue I raised.

@youknowriad
Copy link
Contributor

If you tried it initially, then you only tried it amongst yourselves

Gutenberg was developped in the open from the get go. It is true that the audiance was smaller in the beginning that doesn't mean the feedback was not valuable. As you can see here's the PR that introduced the bahavior #1078 (comment) and the decision was validated after the fact, after testing it.

@youknowriad
Copy link
Contributor

There are a lot of decisions I personally don't agree with and in a project this big, it's not easy to make decisions, we do our best by prototyping, testing, discussing and moving forward (disagree and commit).

Thank you for the thorough discussion. Keep the feedback coming. It's heard and acknowledged and acted upon if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

3 participants