Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocks: Reimplement shared block as embedded editor #12330

Closed
aduth opened this issue Nov 26, 2018 · 1 comment
Closed

Blocks: Reimplement shared block as embedded editor #12330

aduth opened this issue Nov 26, 2018 · 1 comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Code Quality Issues or PRs that relate to code quality
Milestone
WordPress 5.x

Comments

@aduth
Copy link
Member

aduth commented Nov 26, 2018

Previously: #7453

As proposed in the since-closed #7453, we should seek to refactor reusable blocks such that they do not need to exist as a distinct set of state behaviors within the editor store, but rather that the implementation of reusable blocks editing is achieved by creating an embedded editor context (i.e. editor within editor).

cc @noisysocks
@aduth aduth added [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Code Quality Issues or PRs that relate to code quality labels Nov 26, 2018
@aduth aduth added this to the Future: 5.1 milestone Nov 26, 2018
@aduth
Copy link
Member Author

aduth commented Nov 26, 2018

Upon reflection, I think #7119 already encompassed most all of what is described here.

@aduth aduth closed this as completed Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
WordPress 5.x
Development

No branches or pull requests
1 participant
@aduth