Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview Interstitial: Add document title #12462

Closed
swissspidy opened this issue Nov 30, 2018 · 0 comments
Closed

Preview Interstitial: Add document title #12462

swissspidy opened this issue Nov 30, 2018 · 0 comments
Labels
[Feature] Saving Related to saving functionality [Type] Enhancement A suggestion for improvement.

Comments

@swissspidy
Copy link
Member

Right now you'll get a nice WordPress logo animation when loading the preview screen and the text "Generating preview…" underneath it.

Meanwhile, the document title is just "Untitled".

This could also be improved to communicate to the user what's going on. Otherwise you have no idea what that "Untitled" tab is when you have lots of tabs open.

The easiest way is to just set this.previewWindow.document.title = __( 'Generating preview…' );
@swissspidy swissspidy added the [Type] Enhancement A suggestion for improvement. label Nov 30, 2018
@swissspidy swissspidy mentioned this issue Nov 30, 2018
Merged
4 tasks
@designsimply designsimply added the [Feature] Saving Related to saving functionality label Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Saving Related to saving functionality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swissspidy @designsimply