Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks: Add cog to the side of block, as a shortcut to "advanced" inspector controls #1251

Closed
jasmussen opened this issue Jun 19, 2017 · 7 comments
Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels.

Comments

@jasmussen
Copy link
Contributor

Mockup:

screen shot 2017-06-19 at 10 41 56

The cog there on the right will open the inspector when you click it. That is, if the sidebar is closed, it will open the sidebar.

It should show up only when a block has advanced inspector controls (see #1100).

This button can also address an accessibility issue, see #1182. CC: @afercia

@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. labels Jun 19, 2017
@afercia
Copy link
Contributor

afercia commented Jun 19, 2017

Interesting, yes this could help #1182. The tab order will be key, as the cog and delete button should be placed in the most logical order when tabbing. Of course, both buttons would need some aria-label to be properly labeled.

@aduth
Copy link
Member

aduth commented Jun 19, 2017

The tab order will be key, as the cog and delete button should be placed in the most logical order when tabbing.

Do you have any thoughts on what the best tab order would be? It appears visually as though they would occur after the fields, but for consistency with the rest of the controls, I would think they should be part of the series with movers -> toolbar -> cog / delete.

@afercia
Copy link
Contributor

afercia commented Jun 19, 2017

Looking also at #130, yes I tend to think the cog and delete buttons should be part of the movers > toolbar, for consistency and also because it's "one place less" to look at. Not sure about the visual part. The mockup with the delete button within the toolbar makes the logical grouping match the visual grouping, see #130 (comment) and I do like it, just my personal opinion.
On the other hand, separating the bin / trash can icon could maybe help avoiding unwanted destructive actions. Have you considered to ask users to confirm in some way (maybe using something more elegant than a JS confirm) the delete action? As @GaryJones noted on #130, when a block is gone... is gone, no chance of recovery.

@aduth
Copy link
Member

aduth commented Jun 19, 2017

when a block is gone... is gone, no chance of recovery.

Not the intention, though undo / redo is admittedly very basic and incomplete at the moment (partially tracked at #627).

@afercia
Copy link
Contributor

afercia commented Jun 20, 2017

Good to know! 👍

@afercia
Copy link
Contributor

afercia commented Jun 22, 2017

See #1372 that is going to add a "cog" button, however that's used just to open the sidebar.

@mtias
Copy link
Member

mtias commented Jun 26, 2017

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels.
Projects
None yet
Development

No branches or pull requests

4 participants