Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags suggestions: consider to don't save new tags when tabbing away from the input field #1304

Closed
afercia opened this issue Jun 20, 2017 · 7 comments
Labels
Core REST API Task Task for Core REST API efforts [Feature] Document Settings Document settings experience

Comments

@afercia
Copy link
Contributor

afercia commented Jun 20, 2017

Currently, new tags get added when tabbing away from the Tags field in the sidebar. This is not necessarily what users want, as tabbing away from a form field is the standard way to navigate content for users that use the keyboard.

To reproduce:

  • focus the Tags input field in the sidebar
  • type some non-existing tag name
  • press the Tab key to navigate away from the input field
  • at this point, the new tag gets saved
  • check in the Posts > Tags admin screen the new tag is listed

The current behavior in core is different: tags and new tags get added just when explicitly saving (there's a button for this reason). When tabbing away, the only things that happen is wp.a11y.speak sends an audible message to the aria-live regions.

@afercia
Copy link
Contributor Author

afercia commented Jun 20, 2017

Worth noting, when using a keyboard there's the concrete risk to create tons of new, unwanted, tags.

@youknowriad
Copy link
Contributor

youknowriad commented Jun 20, 2017

We're already aware of this, some context here #970 (comment)

The current REST API is not very handy for this use-case.

@afercia
Copy link
Contributor Author

afercia commented Feb 15, 2018

Relevant core ticket: https://core.trac.wordpress.org/ticket/42234
worth noting that change broke the normal interaction when pressing Enter and a better solution should be investigated.

@jeffpaul
Copy link
Member

This ticket was mentioned in Slack in #core-editor by jeffpaul. View the logs.

@jeffpaul jeffpaul added the Needs Design Feedback Needs general design feedback. label Feb 15, 2018
@karmatosed
Copy link
Member

I think design feedback for this is that whatever core does on this we should for tags. It's at least a solid starting point to have same behaviour.

@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Mar 7, 2018
@danielbachhuber
Copy link
Member

@afercia Was this fixed by #6622 and can be closed?

@afercia
Copy link
Contributor Author

afercia commented May 11, 2018

@danielbachhuber yes.

@afercia afercia closed this as completed May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core REST API Task Task for Core REST API efforts [Feature] Document Settings Document settings experience
Projects
None yet
Development

No branches or pull requests

6 participants