Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: can't edit its label and target #1404

Closed
slaFFik opened this issue Jun 23, 2017 · 8 comments
Closed

Button: can't edit its label and target #1404

slaFFik opened this issue Jun 23, 2017 · 8 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.

Comments

@slaFFik
Copy link

slaFFik commented Jun 23, 2017

When adding a button I can enter only its url, but can't edit label and target (_blank for example).

image

Gutenberg v0.2

@slaFFik slaFFik changed the title Button: can't edit it's label and target Button: can't edit its label and target Jun 23, 2017
@mtias
Copy link
Member

mtias commented Jun 23, 2017

By label do you mean the button text?

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement. labels Jun 23, 2017
@slaFFik
Copy link
Author

slaFFik commented Jun 23, 2017

Yes, what is displayed on a button.

@mtias
Copy link
Member

mtias commented Jun 23, 2017

There's an issue with the placeholder text not showing properly so the cursor is missing, but you can edit the text:

image

@slaFFik
Copy link
Author

slaFFik commented Jun 23, 2017

button

Chrome 58, Windows 10 (latest update)

@mtias
Copy link
Member

mtias commented Jun 23, 2017

If you start typing before clicking on the url, does it work?

@mtias mtias added the [Type] Bug An existing feature does not function as intended label Jun 23, 2017
@slaFFik
Copy link
Author

slaFFik commented Jun 23, 2017

Yes. But it's not obvious that I need to actually type inside the block (not in url popover) to change the button text. There is no cursor or active placeholder visible. I understood how to use the block only after you wrote start typing.

@mtias
Copy link
Member

mtias commented Jun 23, 2017

Yes, agreed, that is being iterated on here: #1247

@ellatrix
Copy link
Member

Fixed in #1477.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants